Rocm jaxlib v0.4.31 qa cleanup #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 663524714
Imported from GitHub PR openxla#13597 To ensure proper synchronization for the asynchronous copy, this CL makes the other stream wait for the completion of the operation (res_3) in the main stream. %param_1 = f32[1024]{0} parameter(1) %param_0 = f32[1024]{0} parameter(0) %res_3 = f32[1024]{0} fusion(%param_1, %param_0), kind=kInput, calls=mul %copy-start = (f32[1024]{0:S(5)}, f32[1024]{0}, u32[]) copy-start(f32[1024]{0} %res_3) Copybara import of the project: -- 5e41cc4 by Jane Liu <[email protected]>: Activation offloading dependency fix: insert a wait -- c6c8b3e by Jane Liu <[email protected]>: Assign streams to copy-start instructions and add a Waitfor thunk -- 9ffa12a by Jane Liu <[email protected]>: copy-start always uses a new stream; add Waitfor for both D2H and H2D Merging this change closes openxla#13597 COPYBARA_INTEGRATE_REVIEW=openxla#13597 from zhenying-liu:dependency-fix 9ffa12a PiperOrigin-RevId: 666842831
Imported from GitHub PR openxla#16190 After these changes openxla@d86502a in cuda async allocator were introduced, `PjrtCApiGpuAllocatorTest.ValidOptionsParsing` started failing on ROCm. Copybara import of the project: -- ddc6207 by mmakevic <[email protected]>: Skip cuda_async option for rocm in ValidOptionsParsing test -- 6d491be by mmakevic <[email protected]>: Fix formatting issues Merging this change closes openxla#16190 COPYBARA_INTEGRATE_REVIEW=openxla#16190 from ROCm:ci_pjrt_c_api_test_fix 6d491be PiperOrigin-RevId: 667883110
Imported from GitHub PR openxla#16037 Copybara import of the project: -- 6303981 by Harsha HS <[email protected]>: [ROCm] Distinguish between NVIDIA and AMD gps in `gpu_device_info_test` -- 246e410 by Harsha HS <[email protected]>: Simplify build by removing conditionals as per review comment Merging this change closes openxla#16037 COPYBARA_INTEGRATE_REVIEW=openxla#16037 from ROCm:ci_fix_gpu_device_info_test_20240813 246e410 PiperOrigin-RevId: 663630606
…er_test Imported from GitHub PR openxla#16213 Copybara import of the project: -- 0dba5ad by Harsha HS <[email protected]>: [ROCm] Bump ROCm version to 6.2 and fix gemm_rewriter_test -- 81bea23 by Harsha HS <[email protected]>: Fix clang formatting Merging this change closes openxla#16213 COPYBARA_INTEGRATE_REVIEW=openxla#16213 from ROCm:ci_fix_gemm_rewriter_test_20240819 81bea23 PiperOrigin-RevId: 666859220
hsharsha
requested review from
i-chaochen,
Ruturaj4,
mrodden and
jayfurmanek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.