Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable FP8 rewrite pattern test on ROCm #29

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Disable FP8 rewrite pattern test on ROCm #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions xla/service/gpu/tests/gemm_rewrite_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4791,6 +4791,9 @@ TEST_P(ParameterizedFp8GemmRewriteTest, DoNotRewriteToF8OnPreAda) {
if (HasFp8Support()) {
GTEST_SKIP() << "Test requires a pre-Ada GPU or an AMD GPU prior to MI300.";
}
if (!IsCuda()) {
GTEST_SKIP() << "Skip this rewrite pattern on ROCm";
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is skipped on MI300 due to condition at line 4791. We are skipping this now for pre - Ada GPU prior to MI300 on ROCm 6.2. This is a temporary fix on QA branch until @wenchenvincent has a reproducer against hipBlasLt.

const char* hlo_text = R"(
HloModule test

Expand Down
Loading