Enable triton sparse gemm only for CUDA #27
Draft
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-chaochen
reviewed
Jul 5, 2024
| const HloDotInstruction* dot = Cast<HloDotInstruction>(hlo); | ||
| if (dot->sparse_operands()) { | ||
| return Unimplemented("Sparse dot is supported by Triton emitter only."); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
IIUC, sparse dot will require AddGemmFusionAutotuningPasses and that not only requires triton auotune, but also cudnn fusion front as well.
There was a problem hiding this comment.
This is to unblock JAX to use sparse dot operation. https://github.com/ROCm/frameworks-internal/issues/8118
i-chaochen
approved these changes
Jul 8, 2024
|
Converting to draft as we also need to address failing tests. |
Ruturaj4
reviewed
Jul 12, 2024
| @@ -2921,10 +2921,12 @@ absl::StatusOr<llvm::Value*> ElementalIrEmitter::EmitElementalDot( | |||
| "Algorithm not supported by the ElementalIrEmitter: %s", | |||
| PrecisionConfig::Algorithm_Name(hlo->precision_config().algorithm()))); | |||
| } | |||
| #ifdef GOOGLE_CUDA | |||
There was a problem hiding this comment.
@hsharsha @i-chaochen
I believe better is to use something like ->
#ifndef TENSORFLOW_USE_ROCM
and also ->
local_defines = if_cuda_is_configured(["GOOGLE_CUDA=1"]) + if_rocm_is_configured(["TENSORFLOW_USE_ROCM=1"]),
to //xla/service:elemental_ir_emitter build target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.