-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding in docs #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things I noticed and a few suggestions. It'll probably be easier to review when there is a read the docs build available, but it looks you got all the changes.
Closing and reopening to enable RTD demo build for wysiwyg |
I looked things over in the RTD build and things seemed good. Just one additional comment (the file wasn't updated so I couldn't comment directly) ... I see the license has Copyright © 2022, but I think if we're renaming the component, we should update that to 2024. |
Which file is that coming from? I'll update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates for Metadata headers
It gets picked up from the LICENSE file in the root GitHub directory. |
Okay. I caught that update here: #4 |
@dgaliffiAMD : I think the RTD builds are failing due to this error: error: source '../../source/lib/rocprof-sys-user' is not a readable file or directory... skipping. |
There will be a dependency on #4 being merged first. I'm just trying to parallelize things. :) |
@amd-jnovotny, PR4 has been merged, so I'm rebasing this PR. This should hopefully fix the links. |
@dgaliffiAMD : It looks like docs still aren't working after PR #4 was merged. Is there something else that's needed? |
In the code snippets, the "-" is not valid. ex., rocprof-sys_ --> rocprofsys_
ROCm Systems Profiler, not ROCm Profiler System
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
b88b125
to
3562b2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I noticed a few stray omni references in help options, descriptions, and so forth, in addition to one omniperf reference. Those might not have changed, but I thought I would point them out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Co-authored-by: Jeffrey Novotny <[email protected]>
Sorry. Some of your keyword suggestions were hidden. I just added them. |
No description provided.