-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop stream 2024-10-28 #574
base: develop
Are you sure you want to change the base?
Conversation
ci: set up sccache See merge request amd/libraries/rocRAND!345
Binaries of tests and benchmarks are large with static linking, packing takes about 12 minutes (though these packages are not used).
CI: Run statistical tests Closes ROCm#224 See merge request amd/libraries/rocRAND!344
The host-side generators are only really provided for cuRAND compatibility. Their performance is not really of interest, and removing the TBB dependency eases packaging and maintenance.
Resolve "CPack step takes a long time" Closes ROCm#372 See merge request amd/libraries/rocRAND!348
Resolve "Remove TBB dependency" Closes ROCm#378 See merge request amd/libraries/rocRAND!350
…lop_stream' Resolve "Add small examples to API documentation" Closes ROCm#370 See merge request amd/libraries/rocRAND!351
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few copy edits for you and a couple of questions.
docs(api-reference/cpp-api): improve grammar and punctuation Co-authored-by: Jeffrey Novotny <[email protected]>
Thank you for the grammar and punctuation fixes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs and changelogs changes look good now.
The component owners should review the other changes. My approval only applies to the docs updates. |
This PR adds the following: