Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop stream 2024-10-28 #574

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

Naraenda
Copy link
Member

This PR adds the following:

  • e2a914d Remove TBB depedency.
  • c43bec1 Add usage example to documentation.
  • 5042d17 Fix ODR violation.
  • And some miscellaneous internal CI changes.

Snektron and others added 14 commits October 28, 2024 09:55
ci: set up sccache

See merge request amd/libraries/rocRAND!345
Binaries of tests and benchmarks are large with static linking, packing
takes about 12 minutes (though these packages are not used).
CI: Run statistical tests

Closes ROCm#224

See merge request amd/libraries/rocRAND!344
The host-side generators are only really provided for cuRAND compatibility.
Their performance is not really of interest, and removing the TBB dependency
eases packaging and maintenance.
Resolve "CPack step takes a long time"

Closes ROCm#372

See merge request amd/libraries/rocRAND!348
Resolve "Remove TBB dependency"

Closes ROCm#378

See merge request amd/libraries/rocRAND!350
…lop_stream'

Resolve "Add small examples to API documentation"

Closes ROCm#370

See merge request amd/libraries/rocRAND!351
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few copy edits for you and a couple of questions.

docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
docs/api-reference/cpp-api.rst Outdated Show resolved Hide resolved
Naraenda and others added 2 commits October 28, 2024 05:38
docs(api-reference/cpp-api): improve grammar and punctuation

Co-authored-by: Jeffrey Novotny <[email protected]>
@Naraenda
Copy link
Member Author

Thank you for the grammar and punctuation fixes!

Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and changelogs changes look good now.

@amd-jnovotny
Copy link
Contributor

The component owners should review the other changes. My approval only applies to the docs updates.

@Naraenda Naraenda self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants