Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/2.3] AOTriton build refactor: download binary from github, NO BUILD FROM SOURCE option #1623

Draft
wants to merge 1 commit into
base: release/2.3
Choose a base branch
from
Draft

[release/2.3] AOTriton build refactor: download binary from github, NO BUILD FROM SOURCE option #1623

wants to merge 1 commit into from
+57 −59

Conversation

jithunnair-amd
Copy link
Collaborator

  • AOTriton build refactor: download binary from github, NO BUILD FROM SOURCE option
  • Copy AOTRITON_INSTALLED_PREFIX/* to torch/, Otherwise bdist_wheel will miss libaotriton_v2.so
  • Move all aotriton_version.txt info to aotriton.cmake
  • Consider ROCm version to pick up right tarball
  • Supply ROCM versions and SHA256 checksums as lists.

Changes cherry-picked from pytorch#137443

@jithunnair-amd
AOTriton: download binary from github, NO BUILD FROM SOURCE option
94e2aab 
    Fix tarball's suffix

    Read rocm version from variables set by LoadHIP.cmake

    Copy AOTRITON_INSTALLED_PREFIX/* to torch/

    Otherwise bdist_wheel will miss libaotriton_v2.so

    Fix problems in aotriton.cmake

    Guard against new ROCM environment

    This also updates aotriton_version.txt's format

    Supply ROCM versions and SHA256 checksums as lists.

    Let install_aotriton.sh parse the new format of aotriton_version.txt

    Do not hardcode __AOTRITON_ARCH

    Updates to aotriton build steps and Dockerfiles (#1599)

Changes cherry-picked from pytorch#137443
@jithunnair-amd jithunnair-amd force-pushed the release/2.3_aotriton_build_refactor branch from ea8ffe3 to 94e2aab Compare October 8, 2024 05:45
@rocm-mici
Copy link

Jenkins build for 94e2aab0ed57b03b73a85fb83cc45e9fe1ed028c commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for 94e2aab0ed57b03b73a85fb83cc45e9fe1ed028c commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for 94e2aab0ed57b03b73a85fb83cc45e9fe1ed028c commit finished as SUCCESS
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for 94e2aab0ed57b03b73a85fb83cc45e9fe1ed028c commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for 94e2aab0ed57b03b73a85fb83cc45e9fe1ed028c commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-mici
Copy link

Jenkins build for 94e2aab0ed57b03b73a85fb83cc45e9fe1ed028c commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily will be requested when the pull request is marked ready for review jeffdaily is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jithunnair-amd @rocm-mici