Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop Stream 2024-10-31 #421

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

Develop Stream 2024-10-31 #421

wants to merge 33 commits into from
+1,839 −555

Conversation

NB4444
Copy link
Contributor

@NB4444 NB4444 commented Oct 31, 2024 •
edited
Loading

  • Fix compile error from new rocPRIM version
  • CCCL/cub 2.5.0 compatibility: general changes
  • CCCL/cub 2.5.0 compatibility: expose DeviceSelect::FlaggedIf
  • Add graph capture tests for device run length encode
  • Update hipCUP tests and benchmarks default to c++17
  • Cleanup hipcub/backend/rocprim/grid/grid_queue.h

Requires ROCm/rocPRIM#631 to compile for expose DeviceSelect::FlaggedIf.

sbalint98 and others added 27 commits October 30, 2024 10:18
@sbalint98 @NB4444
Resolve "hipCUB compilation fails with latest rocPRIM changes"
fec62de
@Beanavil @NB4444
Rework device_histogram test
97660ce
@Beanavil @NB4444
Const-qualify half_t::operator+/*
68a439f
@Beanavil @NB4444
Update CUB/Thrust/libcu++ to 2.5.0
c58c2a3
@Beanavil @NB4444
Add tets for large number of items for hipcub::DeviceSelect::If
2281933
@Beanavil @NB4444
Update example_device_radix_sort.cu
dd0b00c
@Beanavil @NB4444
fix: reset error code in device_radix_sort test after out-of-memory e…
03e836a 
…rror
@Beanavil @NB4444
Expose DeviceSelect::FlaggedIf
f0bb576
@Beanavil @NB4444
Add test for DeviceSelect::FlaggedIf
01e1304
@Beanavil @NB4444
Add benchmark for DeviceSelect::FlaggedIf
fbe5761
@Beanavil @NB4444
Add hipGraph capture tests for device run length encode
001509e
@NB4444
Set c++ version to 17 and create warning
30e0957
@NB4444
Fix ambiguous variable error
88addb0
@NB4444
Fix nodiscard warnings
48615a1
@NB4444
Set CI tests for both c++14 and 17
1b72fbc
@NB4444
Fix nodiscard warnings in example
f5ece38
@NB4444
Examples clang-format
4ef0aed
@NB4444
Fixed clang format and dates
89875a4
@NB4444
temp fix: wrong error on cuda machines
1b65b61
@NB4444
Ignore error from hipGetLastError to prevent warning
7492686
@Saiyang-Zhang @NB4444
Deleted declaration of unecessary hipError_t result
da3b221
@Saiyang-Zhang @NB4444
Deleted declaration of unecessary hipError_t result
6e29b14
@Saiyang-Zhang @NB4444
Format amending
43186b3
@Saiyang-Zhang @NB4444
Format amending
d560631
@Saiyang-Zhang @NB4444
Format amending
419ac42
@Saiyang-Zhang @NB4444
Cleanup
b46c259
@Saiyang-Zhang @NB4444
Formatting
2093675
@NB4444
Copy link
Contributor Author

NB4444 commented Nov 6, 2024

I have also added a fix for the temp fix commit. The BindTexture functions returned a cudaError now with a wrapper function it returns a hipError on all machines.

@umfranzw umfranzw self-requested a review November 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NB4444 @umfranzw @sbalint98 @Beanavil @Saiyang-Zhang