Set Python_ROOT virtual.env #1344
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellosel
added
the
noCI
ellosel
added
ci:testonly
and removed
noCI
ellosel
requested review from
jichangjichang,
KKyang,
aazz44ss,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were environment changes in more recent images that introduced another python installation in /usr/local. As a result, cmake tends to find the /usr/local/bin/python3 rather than /usr/bin/python3 (that latter is preferred) because /usr/local/bin appears before /usr/bin in the PATH variable.
CMake will attempt to find python via the Python_ROOT variable first if it is set. This change sets the Python_ROOT to /usr if it is unset. This will restore previous "out-of-the-box" behavior.