Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune Aldebaran BF16 NN TN NT GEMM sizes #1323

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Tune Aldebaran BF16 NN TN NT GEMM sizes #1323

wants to merge 2 commits into from
+5,596 −0

Conversation

aferoz21
Copy link
Contributor

@aferoz21 aferoz21 commented Nov 7, 2024

Aldebaran BF16 NN, NT, TN Gemm sizes tuned , approximately 16% improvement done.

@aferoz21 aferoz21 self-assigned this Nov 7, 2024
babakpst
babakpst previously approved these changes Nov 8, 2024
View reviewed changes
jichangjichang
jichangjichang reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@jichangjichang jichangjichang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic yaml's file name should contain 'UserArgs'. Please check why it is missing.

@aferoz21
Copy link
Contributor Author

The logic yaml's file name should contain 'UserArgs'. Please check why it is missing.
Now I have added back "UserArgs". Earlier I removed that to match with existing library names. but looks it was generated a very long time back. but even without *UserArgs correct kernel was picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang jichangjichang left review comments

@babakpst babakpst babakpst left review comments

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@aazz44ss aazz44ss Awaiting requested review from aazz44ss aazz44ss is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@aferoz21 aferoz21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aferoz21 @babakpst @jichangjichang