New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ck's grouped convolution fwd instances #3392

Open

linsun12 wants to merge 1 commit into develop from linsun/convint8_ck_solver

+7 −5

linsun12 commented Nov 16, 2024

This PR is for enabling ck's grouped convolution fwd instances inside MIOpen.
Changes are minor and the goal is to

change the output datatype to int8 for consistency between input datatype and output datatype. The int32 as output datatype for convint8 was legacy code from previous customer request and is no longer used.
Enable int8 datatype for naive_conv solver as reference solver for validating output
commit hash for composable kernel is switched to ck's merged PR for adding convint8 fwd instances on ck's develop branch.


          enable convint8 ck instances

e4d47a4

linsun12 requested a review from iq136boy

November 16, 2024 01:32

linsun12 requested review from BrianHarrisonAMD, junliume and BradPepersAMD as code owners

November 16, 2024 01:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iq136boy Awaiting requested review from iq136boy

BrianHarrisonAMD Awaiting requested review from BrianHarrisonAMD BrianHarrisonAMD is a code owner

junliume Awaiting requested review from junliume junliume is a code owner

BradPepersAMD Awaiting requested review from BradPepersAMD BradPepersAMD is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet