Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initialization and error handling #3632

Open
wants to merge 4 commits into
base: hip_runtime_api_how-to
Choose a base branch
from
Open

Add initialization and error handling #3632

wants to merge 4 commits into from

Conversation

matyas-streamhpc
Copy link

No description provided.

@matyas-streamhpc matyas-streamhpc changed the title Initialization error handling Add initialization and error handling Oct 4, 2024
@neon60 neon60 force-pushed the initialization_error_handling branch 6 times, most recently from c1cb391 to 17d22fe Compare October 9, 2024 12:12
@neon60 neon60 changed the base branch from docs/develop to hip_runtime_api_how-to October 9, 2024 12:13
@neon60 neon60 marked this pull request as ready for review October 9, 2024 12:13
@neon60 neon60 requested a review from MKKnorr October 9, 2024 12:13
MKKnorr
MKKnorr reviewed Oct 10, 2024
View reviewed changes
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
MKKnorr
MKKnorr reviewed Oct 10, 2024
View reviewed changes
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
@neon60 neon60 force-pushed the initialization_error_handling branch from 0a8fd46 to 7421ee9 Compare October 11, 2024 06:53
@neon60 neon60 requested a review from MKKnorr October 11, 2024 06:53
@neon60 neon60 force-pushed the initialization_error_handling branch 2 times, most recently from aad09d3 to 63f04da Compare October 11, 2024 08:09
@neon60 neon60 force-pushed the initialization_error_handling branch 2 times, most recently from fae2b59 to d6bc663 Compare October 15, 2024 05:40
randyh62
randyh62 approved these changes Oct 17, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a good start to the topic. Are there other error catching functions or datatypes that could be included here beyond the launching of kernels?

docs/index.md Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/error_handling.rst Show resolved Hide resolved
@neon60 neon60 force-pushed the initialization_error_handling branch from 579f698 to d84fc74 Compare October 21, 2024 11:54
@neon60
Copy link
Contributor

neon60 commented Oct 21, 2024

This feels like a good start to the topic. Are there other error catching functions or datatypes that could be included here beyond the launching of kernels?

The PR mentioning all the functions and return type, which are related to HIP error handling: https://rocm.docs.amd.com/projects/HIP/en/latest/doxygen/html/group___error.html

@neon60 neon60 requested a review from randyh62 October 21, 2024 19:27
randyh62
randyh62 approved these changes Oct 23, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it could use a few more details though.

docs/how-to/hip_runtime_api/initialization.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/initialization.rst Show resolved Hide resolved
randyh62
randyh62 approved these changes Oct 23, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@neon60 neon60 force-pushed the initialization_error_handling branch from a7a88a4 to 3a485ac Compare October 30, 2024 09:14
@neon60 neon60 force-pushed the initialization_error_handling branch from 3a485ac to 1e3e28b Compare November 5, 2024 08:14
@neon60 neon60 force-pushed the hip_runtime_api_how-to branch 2 times, most recently from eb41cb1 to 7cb026c Compare November 7, 2024 12:00
@neon60 neon60 force-pushed the initialization_error_handling branch from 1e3e28b to d8e45e7 Compare November 7, 2024 12:23
@neon60 neon60 force-pushed the initialization_error_handling branch from d8e45e7 to 0d23a51 Compare November 11, 2024 12:19
@neon60 neon60 force-pushed the initialization_error_handling branch from 0d23a51 to 58fcb32 Compare November 11, 2024 12:20
satyanveshd
satyanveshd approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@satyanveshd satyanveshd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKKnorr MKKnorr MKKnorr approved these changes

@satyanveshd satyanveshd satyanveshd approved these changes

@randyh62 randyh62 randyh62 approved these changes

@neon60 neon60 Awaiting requested review from neon60

@chrispaquot chrispaquot Awaiting requested review from chrispaquot chrispaquot is a code owner

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@saleelk saleelk Awaiting requested review from saleelk saleelk is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matyas-streamhpc @neon60 @randyh62 @satyanveshd @MKKnorr