Fixed multilevel pointer conversion tidy check errors and re-enable t… #3615
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedThemistokleous
added
the
Cleanup
test/operation.cpp
Outdated
| EXPECT(test::throws([&] { migraphx::any_cast<not_operation&>(op1); })); | ||
| migraphx::operation op2 = simple_operation{2}; | ||
| EXPECT(migraphx::any_cast<simple_operation>(op2).data == 2); | ||
| EXPECT(migraphx::any_cast<not_operation*>(&op2) == nullptr); |
There was a problem hiding this comment.
We shouldn't be modifying the test for this. Those checks are there to ensure that these resolve correctly.
There was a problem hiding this comment.
Added the tests back
| @@ -134,7 +134,7 @@ void kernel::launch(hipStream_t stream, | |||
| hipEvent_t stop) const | |||
| { | |||
| assert(impl != nullptr); | |||
| void* kernargs = args.data(); | |||
| void* kernargs = reinterpret_cast<void*>(args.data()); | |||
There was a problem hiding this comment.
This makes sense here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3615 +/- ##
========================================
Coverage 92.18% 92.18%
========================================
Files 513 513
Lines 21576 21576
========================================
Hits 19889 19889
Misses 1687 1687 ☔ View full report in Codecov by Sentry. |
taylding-amd
force-pushed
the
issue_3472
branch
from
2e34b44
to
1a2b5bf
Compare
There was a problem hiding this comment.
Looks good. Handle the format/tidy checks that are failing.
seeing this in the tidy check now.
57880 warnings generated.
Warning: multilevel pointer conversion from 'const char **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion,-warnings-as-errors]
172 | dnnl_primitive_desc_query(desc, dnnl_query_impl_info_str, 0, &str);
| ^
CMake Error at tidy-target-migraphx_cpu-pooling_cpp.cmake:83 (message):
Clang tidy failed.
make[3]: *** [src/targets/cpu/CMakeFiles/tidy-target-migraphx_cpu-pooling_cpp.dir/build.make:71: src/targets/cpu/CMakeFiles/tidy-target-migraphx_cpu-pooling_cpp] Error 1
make[3]: Target 'src/targets/cpu/CMakeFiles/tidy-target-migraphx_cpu-pooling_cpp.dir/build' not remade because of errors.
make[2]: *** [CMakeFiles/Makefile2:18026: src/targets/cpu/CMakeFiles/tidy-target-migraphx_cpu-pooling_cpp.dir/all] Error 2
[ 20%] clang-tidy: Running clang-tidy on target compile_miopen.cpp...
59009 warnings generated.
Warning: multilevel pointer conversion from 'const char **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion,-warnings-as-errors]
172 | dnnl_primitive_desc_query(desc, dnnl_query_impl_info_str, 0, &str);
|
Format you can use with a git hook for formatting. check in tools/format.py
taylding-amd
force-pushed
the
issue_3472
branch
from
8176666
to
27330aa
Compare
taylding-amd
force-pushed
the
issue_3472
branch
from
118a810
to
3b724aa
Compare
taylding-amd
force-pushed
the
issue_3472
branch
from
df38b0e
to
c729117
Compare
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3472, fix the multilevel pointer conversion tidy check, and re-enable the check. I had to remove a couple of not_operation checks to pass the tidy check.