Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue115 #131

Closed
wants to merge 2 commits into from
Closed

Issue115 #131

wants to merge 2 commits into from

Conversation

johnauld
Copy link

@johnauld johnauld commented Aug 8, 2023

This fixes #115. The problem described in that issue is that SerialPortHandler::begin() calls delay() unconditionally, which causes a hang if interrupts are disabled at the time of the call (as is the case during FreeRTOS startup).

The solution here is to add a uint32_t delay parameter to Dynamixel2Arduino::begin() and SerialPortHandler::begin() to allow the caller to specify the amount of delay, or to disable the delay() call entirely by passing zero.

The change is backward-compatible. No existing code will be affected, since both functions provide a default value of 500 (which is equal to the previous, recently changed, hard-coded delay time).

@johnauld johnauld closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant