Issue #115 - allow override of hard-coded delay #116
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for issue #115. The problem there is that
SerialPortHandler::begin()
callsdelay()
unconditionally, which causes a hang if interrupts are disabled at the time of the call (as is the case during FreeRTOS startup).The solution here is to add a
uint32_t delay
parameter toDynamixel2Arduino::begin()
andSerialPortHandler::begin()
to allow the caller to specify the amount of delay, or to disable thedelay()
call entirely by passing zero. For both functions, a default value of 300 is provided (equal to the previous hard-coded delay time), so existing code will be unaffected.