Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #115 - allow override of hard-coded delay #116

Closed
wants to merge 2 commits into from
Closed

Issue #115 - allow override of hard-coded delay #116

wants to merge 2 commits into from

Conversation

johnauld
Copy link

@johnauld johnauld commented Nov 30, 2022

This is a proposed fix for issue #115. The problem there is that SerialPortHandler::begin() calls delay() unconditionally, which causes a hang if interrupts are disabled at the time of the call (as is the case during FreeRTOS startup).

The solution here is to add a uint32_t delay parameter to Dynamixel2Arduino::begin() and SerialPortHandler::begin() to allow the caller to specify the amount of delay, or to disable the delay() call entirely by passing zero. For both functions, a default value of 300 is provided (equal to the previous hard-coded delay time), so existing code will be unaffected.

@johnauld johnauld changed the base branch from master to develop January 11, 2023 21:05
@johnauld johnauld closed this Aug 8, 2023
@johnauld johnauld deleted the issue115 branch August 8, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant