Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/13 docker build #14

Merged
merged 18 commits into from
May 30, 2024
Merged

Fix/13 docker build #14

merged 18 commits into from
May 30, 2024

Conversation

AlexAxthelm
Copy link
Contributor

  • Use standard RMI-PACTA/actions for docker

Closes #10

AlexAxthelm added a commit to RMI-PACTA/workflow.pacta that referenced this pull request May 28, 2024
@AlexAxthelm
Set USER earlier in Dockerfile
c1b6db0 
Create the workflow-pacta user immediately after installing system
dependencies, and add that user to `staff` group, giving permissions to
install R packages to the site library.

No assosciated issue, reflecting practice in
RMI-PACTA/workflow.pacta.report#14
@AlexAxthelm AlexAxthelm mentioned this pull request May 28, 2024
Closed
@AlexAxthelm
Copy link
Contributor Author

@cjyetman @jdhoffa I've spent most of today trying to diagnose package installation, which is failing for a reason I don't entirely understand. Issue opened on pak r-lib/pak#638

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

Docker build status

commit_time git_sha image
2024-05-29T13:28:26Z 98da684 ghcr.io/rmi-pacta/workflow.pacta.report:pr-14

@AlexAxthelm AlexAxthelm mentioned this pull request May 29, 2024
Open
@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 29, 2024 13:39
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa May 29, 2024 13:39
@AlexAxthelm
Copy link
Contributor Author

Opening for review. I'm not incredibly happy about this PR. as it stands, since I'm effectively re-implementing the Dockerfile from workflow.pacta, as a response to not being able to R install packages if I inherit from workflow.pacta:main.

#16 opened to track that particular part.

@AlexAxthelm AlexAxthelm mentioned this pull request May 29, 2024
Closed
11 tasks
jdhoffa
jdhoffa approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I agree it is clunky to completely re-write the workflow.pacta docker image

@AlexAxthelm AlexAxthelm merged commit b40ae85 into main May 30, 2024
5 checks passed
@AlexAxthelm AlexAxthelm deleted the fix/13-docker-build branch May 30, 2024 07:04
@AlexAxthelm AlexAxthelm mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up CI/CD pipeline
2 participants
@AlexAxthelm @jdhoffa