build(docker): #220 Add standard RMI docker workflow #221

AlexAxthelm · 2024-04-16T15:58:36Z

Closes: #220

github-actions · 2024-04-16T16:01:19Z

Docker build status

Commit time	Git sha	Image
2024-04-30T16:03:11Z	`2992bca`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221

History

Commit time	Git sha	Image
2024-04-30T16:03:11Z	`2992bca`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-23T07:36:37Z	`d76aa51`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-18T13:48:47Z	`42a7931`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-18T10:04:43Z	`cf2f9b2`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-17T14:37:34Z	`da40f44`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-17T14:31:03Z	`11d769e`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-17T14:06:18Z	`9ac9389`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-17T13:18:10Z	`c308f3f`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-17T11:53:59Z	`7379992`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221
2024-04-16T15:58:36Z	`b1ef431`	ghcr.io/rmi-pacta/workflow.data.preparation:pr-221

History JSON

`[{"commit_time":"2024-04-30T16:03:11Z","git_sha":"2992bca43b3de66fa7474dedd09095358f3fce9b","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-23T07:36:37Z","git_sha":"d76aa51464363697613a7e3bee05f01f8920692d","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-18T13:48:47Z","git_sha":"42a7931b7053a666eaefea9c5c4bb42b9805db96","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-18T10:04:43Z","git_sha":"cf2f9b2b921d8587b4972dcf5e419b4564e3bf94","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-17T14:37:34Z","git_sha":"da40f4449e5612ef5d9cced97b24e385047aea76","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-17T14:31:03Z","git_sha":"11d769e6e518d3bd50d2c1c41d096cce7010816a","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-17T14:06:18Z","git_sha":"9ac93897716b33a5de543e1cd16a232fc87ed72a","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-17T13:18:10Z","git_sha":"c308f3f96e6232ed21debe7a9b1bd1b5fba9bf30","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-17T11:53:59Z","git_sha":"7379992ae72dd7e491f3c5f4561bf657dc964725","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"},{"commit_time":"2024-04-16T15:58:36Z","git_sha":"b1ef431f1658f55602325c05c9af663444fc6137","image":"ghcr.io/rmi-pacta/workflow.data.preparation:pr-221"}]`

cjyetman · 2024-04-16T16:03:31Z

Do we need a Docker image created automatically on each PR? Also not a fan of the aggressive linting.

AlexAxthelm · 2024-04-16T16:10:37Z

Do we need a Docker image created automatically on each PR?

I think doing a build, but not running on each PR makes sense.

Also not a fan of the aggressive linting.

hadolint?

cjyetman · 2024-04-16T16:31:33Z

Closes #220

cjyetman

Please move changes to the Docker file to a separate PR with appropriate documentation of the reasoning for them.

AlexAxthelm · 2024-04-18T10:04:33Z

I believe those changes are relevant to this PR, since they are cleaning up the Dockerfile so that hadolint and the check R system dependencies actions (which are introduced here) pass cleanly.

cjyetman · 2024-04-18T12:00:48Z

For example, building a linux/amd64 image is essentially a requirement, and removing that specification from the Dockerfile forces me to manually specify it every time I run this. So I'm very unlikely to approve something that both:

has a negative impact on how I use/develop/maintain this repo
has the exclusive purpose of satisfying and overly aggressive lintr that I'd rather not have here in the first place

AlexAxthelm · 2024-04-18T13:50:47Z

I've restored the --platform=linux/amd64 in the FROM command, and told hadolint to exclude that check.

The rest of the changes to the Dockerfile are reasonable, and in line with best practices.

cjyetman · 2024-04-20T08:18:55Z

Where does cmake come from?

pak::pkg_sysreqs(pkg = "rmi-pacta/workflow.data.preparation", sysreqs_platform = "ubuntu-20.04")
#> ℹ Loading metadata database
#> ✔ Loading metadata database ... done
#> 
#> ── Install scripts ───────────────────────────────────────────── Ubuntu 20.04 ──
#> apt-get -y update
#> apt-get -y install libicu-dev libxml2-dev git libcurl4-openssl-dev libssl-dev \
#>   make libgit2-dev zlib1g-dev pandoc libfreetype6-dev libjpeg-dev libpng-dev \
#>   libtiff-dev libfontconfig1-dev libfribidi-dev libharfbuzz-dev libnode-dev
#> 
#> ── Packages and their system dependencies ──────────────────────────────────────
#> credentials – git
#> curl        – libcurl4-openssl-dev, libssl-dev
#> fs          – make
#> gert        – libgit2-dev
#> gitcreds    – git
#> httpuv      – make, zlib1g-dev
#> knitr       – pandoc
#> openssl     – libssl-dev
#> pkgdown     – pandoc
#> ragg        – libfreetype6-dev, libjpeg-dev, libpng-dev, libtiff-dev
#> remotes     – git
#> rmarkdown   – pandoc
#> sass        – make
#> stringi     – libicu-dev
#> systemfonts – libfontconfig1-dev, libfreetype6-dev
#> textshaping – libfreetype6-dev, libfribidi-dev, libharfbuzz-dev
#> V8          – libnode-dev
#> xml2        – libxml2-dev
pak::pkg_sysreqs(pkg = "rmi-pacta/workflow.data.preparation", sysreqs_platform = "ubuntu-22.04")
#> ── Install scripts ───────────────────────────────────────────── Ubuntu 22.04 ──
#> apt-get -y update
#> apt-get -y install libicu-dev git libcurl4-openssl-dev libssl-dev make \
#>   libgit2-dev zlib1g-dev pandoc libfreetype6-dev libjpeg-dev libpng-dev \
#>   libtiff-dev libfontconfig1-dev libfribidi-dev libharfbuzz-dev libxml2-dev \
#>   libnode-dev
#> 
#> ── Packages and their system dependencies ──────────────────────────────────────
#> credentials – git
#> curl        – libcurl4-openssl-dev, libssl-dev
#> fs          – make
#> gert        – libgit2-dev
#> gitcreds    – git
#> httpuv      – make, zlib1g-dev
#> knitr       – pandoc
#> openssl     – libssl-dev
#> pkgdown     – pandoc
#> ragg        – libfreetype6-dev, libjpeg-dev, libpng-dev, libtiff-dev
#> remotes     – git
#> rmarkdown   – pandoc
#> sass        – make
#> stringi     – libicu-dev
#> systemfonts – libfontconfig1-dev, libfreetype6-dev
#> textshaping – libfreetype6-dev, libfribidi-dev, libharfbuzz-dev
#> V8          – libnode-dev
#> xml2        – libxml2-dev

AlexAxthelm · 2024-04-23T07:36:33Z

Where does cmake come from?

arrow https://github.com/RMI-PACTA/workflow.data.preparation/actions/runs/8723361031/job/23931519811#step:3:17

cjyetman · 2024-04-23T07:47:41Z

why does it think this needs arrow?

cjyetman · 2024-04-24T05:30:30Z

I'm pretty sure pak::sysreqs_check_installed() (used here https://github.com/RMI-PACTA/actions/blob/ff62270b68b67c387bf388372ad667b21e6b8fca/.github/workflows/docker-check-R-sysdeps.yml#L20C20-L20C50) is looking for all development dependencies including those in Suggests, which is picking up arrow from DBI.

https://github.com/r-dbi/DBI/blob/6382f918a56b78eb832348e0eedb538a6721286a/DESCRIPTION#L22-L23

pak::pkg_deps_tree("DBI")
#> ℹ Loading metadata database
#> ✔ Loading metadata database ... done
#> 
#> DBI 1.2.2 ✨
#> 
#> Key:  ✨ new
pak::pkg_deps_tree("DBI", dependencies = TRUE)
#> DBI 1.2.2 ✨
#> ├─arrow 15.0.1 ✨👷🏽‍♀️🔧 ⬇ (4.37 MB)
#> │ ├─assertthat 0.2.1 ✨ ⬇ (53.25 kB)
#> │ ├─bit64 4.0.5 ✨🔧
#> │ │ └─bit 4.0.5 ✨🔧
#> │ ├─glue 1.7.0 ✨🔧
#> │ ├─purrr 1.0.2 ✨🔧
#> │ │ ├─cli 3.6.2 ✨🔧
#> │ │ ├─lifecycle 1.0.4 ✨
#> │ │ │ ├─cli
#> │ │ │ ├─glue
#> │ │ │ └─rlang 1.1.3 ✨🔧
#> │ │ ├─magrittr 2.0.3 ✨🔧
#> │ │ ├─rlang
#> │ │ └─vctrs 0.6.5 ✨🔧
#> │ │   ├─cli
#> │ │   ├─glue
#> │ │   ├─lifecycle
#> │ │   └─rlang
#> │ ├─R6 2.5.1 ✨
#> │ ├─rlang
#> │ ├─tidyselect 1.2.1 ✨🔧 ⬇ (224.10 kB)
#> │ │ ├─cli
#> │ │ ├─glue
#> │ │ ├─lifecycle
#> │ │ ├─rlang
#> │ │ ├─vctrs
#> │ │ └─withr 3.0.0 ✨
#> │ ├─vctrs
#> │ └─cpp11 0.4.7 ✨ ⬇ (280.86 kB)
#> ├─blob 1.2.4 ✨
#> │ ├─rlang
#> │ └─vctrs
#> ├─covr 3.6.4 ✨🔧 ⬇ (332.09 kB)
#> │ ├─digest 0.6.35 ✨🔧 ⬇ (352.09 kB)
#> │ ├─jsonlite 1.8.8 ✨🔧
#> │ ├─rex 1.2.1 ✨ ⬇ (123.81 kB)
#> │ │ └─lazyeval 0.2.2 ✨🔧
#> │ ├─httr 1.4.7 ✨
#> │ │ ├─curl 5.2.1 ✨🔧 ⬇ (813.53 kB)
#> │ │ ├─jsonlite
#> │ │ ├─mime 0.12 ✨🔧
#> │ │ ├─openssl 2.1.2 ✨🔧
#> │ │ │ └─askpass 1.2.0 ✨🔧
#> │ │ │   └─sys 3.4.2 ✨🔧
#> │ │ └─R6
#> │ ├─crayon 1.5.2 ✨
#> │ ├─withr
#> │ └─yaml 2.3.8 ✨🔧
#> ├─DBItest 1.8.1 ✨ ⬇ (1.95 MB)
#> │ ├─blob
#> │ ├─callr 3.7.6 ✨ ⬇ (437.50 kB)
#> │ │ ├─processx 3.8.4 ✨🔧 ⬇ (317.66 kB)
#> │ │ │ ├─ps 1.7.6 ✨🔧
#> │ │ │ └─R6
#> │ │ └─R6
#> │ ├─DBI
#> │ ├─desc 1.4.3 ✨
#> │ │ ├─cli
#> │ │ └─R6
#> │ ├─hms 1.1.3 ✨
#> │ │ ├─lifecycle
#> │ │ ├─pkgconfig 2.0.3 ✨
#> │ │ ├─rlang
#> │ │ └─vctrs
#> │ ├─lubridate 1.9.3 ✨🔧
#> │ │ ├─generics 0.1.3 ✨
#> │ │ └─timechange 0.3.0 ✨🔧
#> │ │   └─cpp11
#> │ ├─magrittr
#> │ ├─nanoarrow 0.4.0.1 ✨🔧 ⬇ (444.85 kB)
#> │ ├─palmerpenguins 0.1.1 ✨ ⬇ (3.00 MB)
#> │ ├─rlang
#> │ ├─testthat 3.2.1.1 ✨🔧
#> │ │ ├─brio 1.1.4 ✨🔧
#> │ │ ├─callr
#> │ │ ├─cli
#> │ │ ├─desc
#> │ │ ├─digest
#> │ │ ├─evaluate 0.23 ✨
#> │ │ ├─jsonlite
#> │ │ ├─lifecycle
#> │ │ ├─magrittr
#> │ │ ├─pkgload 1.3.4 ✨ ⬇ (180.17 kB)
#> │ │ │ ├─cli
#> │ │ │ ├─crayon
#> │ │ │ ├─desc
#> │ │ │ ├─fs 1.6.3 ✨🔧
#> │ │ │ ├─glue
#> │ │ │ ├─pkgbuild 1.4.4 ✨ ⬇ (202.24 kB)
#> │ │ │ │ ├─callr
#> │ │ │ │ ├─cli
#> │ │ │ │ ├─desc
#> │ │ │ │ ├─processx
#> │ │ │ │ └─R6
#> │ │ │ ├─rlang
#> │ │ │ ├─rprojroot 2.0.4 ✨
#> │ │ │ └─withr
#> │ │ ├─praise 1.0.0 ✨ ⬇ (16.52 kB)
#> │ │ ├─processx
#> │ │ ├─ps
#> │ │ ├─R6
#> │ │ ├─rlang
#> │ │ ├─waldo 0.5.2 ✨ ⬇ (103.51 kB)
#> │ │ │ ├─cli
#> │ │ │ ├─diffobj 0.3.5 ✨🔧 ⬇ (1.02 MB)
#> │ │ │ │ └─crayon
#> │ │ │ ├─fansi 1.0.6 ✨🔧
#> │ │ │ ├─glue
#> │ │ │ ├─rematch2 2.1.2 ✨
#> │ │ │ │ └─tibble 3.2.1 ✨🔧
#> │ │ │ │   ├─fansi
#> │ │ │ │   ├─lifecycle
#> │ │ │ │   ├─magrittr
#> │ │ │ │   ├─pillar 1.9.0 ✨
#> │ │ │ │   │ ├─cli
#> │ │ │ │   │ ├─fansi
#> │ │ │ │   │ ├─glue
#> │ │ │ │   │ ├─lifecycle
#> │ │ │ │   │ ├─rlang
#> │ │ │ │   │ ├─utf8 1.2.4 ✨🔧
#> │ │ │ │   │ └─vctrs
#> │ │ │ │   ├─pkgconfig
#> │ │ │ │   ├─rlang
#> │ │ │ │   └─vctrs
#> │ │ │ ├─rlang
#> │ │ │ └─tibble
#> │ │ └─withr
#> │ └─withr
#> ├─dbplyr 2.5.0 ✨ ⬇ (1.23 MB)
#> │ ├─blob
#> │ ├─cli
#> │ ├─DBI
#> │ ├─dplyr 1.1.4 ✨🔧
#> │ │ ├─cli
#> │ │ ├─generics
#> │ │ ├─glue
#> │ │ ├─lifecycle
#> │ │ ├─magrittr
#> │ │ ├─pillar
#> │ │ ├─R6
#> │ │ ├─rlang
#> │ │ ├─tibble
#> │ │ ├─tidyselect
#> │ │ └─vctrs
#> │ ├─glue
#> │ ├─lifecycle
#> │ ├─magrittr
#> │ ├─pillar
#> │ ├─purrr
#> │ ├─R6
#> │ ├─rlang
#> │ ├─tibble
#> │ ├─tidyr 1.3.1 ✨🔧
#> │ │ ├─cli
#> │ │ ├─dplyr
#> │ │ ├─glue
#> │ │ ├─lifecycle
#> │ │ ├─magrittr
#> │ │ ├─purrr
#> │ │ ├─rlang
#> │ │ ├─stringr 1.5.1 ✨
#> │ │ │ ├─cli
#> │ │ │ ├─glue
#> │ │ │ ├─lifecycle
#> │ │ │ ├─magrittr
#> │ │ │ ├─rlang
#> │ │ │ ├─stringi 1.8.3 ✨🔧
#> │ │ │ └─vctrs
#> │ │ ├─tibble
#> │ │ ├─tidyselect
#> │ │ ├─vctrs
#> │ │ └─cpp11
#> │ ├─tidyselect
#> │ ├─vctrs
#> │ └─withr
#> ├─downlit 0.4.3 ✨
#> │ ├─brio
#> │ ├─desc
#> │ ├─digest
#> │ ├─evaluate
#> │ ├─fansi
#> │ ├─memoise 2.0.1 ✨
#> │ │ ├─rlang
#> │ │ └─cachem 1.0.8 ✨🔧
#> │ │   ├─rlang
#> │ │   └─fastmap 1.1.1 ✨🔧
#> │ ├─rlang
#> │ ├─vctrs
#> │ ├─withr
#> │ └─yaml
#> ├─dplyr
#> ├─glue
#> ├─hms
#> ├─knitr 1.46 ✨
#> │ ├─evaluate
#> │ ├─highr 0.10 ✨
#> │ │ └─xfun 0.43 ✨🔧 ⬇ (488.05 kB)
#> │ ├─xfun
#> │ └─yaml
#> ├─magrittr
#> ├─nanoarrow
#> ├─RMariaDB 1.3.1 ✨👷🏽‍♀️🔧 ⬇ (908.03 kB)
#> │ ├─bit64
#> │ ├─blob
#> │ ├─DBI
#> │ ├─hms
#> │ ├─lubridate
#> │ ├─rlang
#> │ ├─cpp11
#> │ └─plogr 0.2.0 ✨ ⬇ (13.28 kB)
#> ├─rmarkdown 2.26 ✨ ⬇ (2.62 MB)
#> │ ├─bslib 0.7.0 ✨ ⬇ (5.33 MB)
#> │ │ ├─base64enc 0.1-3 ✨🔧
#> │ │ ├─cachem
#> │ │ ├─fastmap
#> │ │ ├─htmltools 0.5.8.1 ✨🔧 ⬇ (359.58 kB)
#> │ │ │ ├─base64enc
#> │ │ │ ├─digest
#> │ │ │ ├─fastmap
#> │ │ │ └─rlang
#> │ │ ├─jquerylib 0.1.4 ✨
#> │ │ │ └─htmltools
#> │ │ ├─jsonlite
#> │ │ ├─lifecycle
#> │ │ ├─memoise
#> │ │ ├─mime
#> │ │ ├─rlang
#> │ │ └─sass 0.4.9 ✨🔧 ⬇ (2.41 MB)
#> │ │   ├─fs
#> │ │   ├─rlang
#> │ │   ├─htmltools
#> │ │   ├─R6
#> │ │   └─rappdirs 0.3.3 ✨🔧
#> │ ├─evaluate
#> │ ├─fontawesome 0.5.2 ✨
#> │ │ ├─rlang
#> │ │ └─htmltools
#> │ ├─htmltools
#> │ ├─jquerylib
#> │ ├─jsonlite
#> │ ├─knitr
#> │ ├─tinytex 0.50 ✨ ⬇ (139.62 kB)
#> │ │ └─xfun
#> │ ├─xfun
#> │ └─yaml
#> ├─rprojroot
#> ├─RSQLite 2.3.6 ✨🔧 ⬇ (4.37 MB)
#> │ ├─bit64
#> │ ├─blob
#> │ ├─DBI
#> │ ├─memoise
#> │ ├─pkgconfig
#> │ ├─rlang
#> │ ├─plogr
#> │ └─cpp11
#> ├─testthat
#> ├─vctrs
#> └─xml2 1.3.6 ✨🔧
#>   ├─cli
#>   └─rlang
#> 
#> Key:  ✨ new |  ⬇ download | 👷🏽‍♀️ build | 🔧 compile

jdhoffa · 2024-04-24T07:39:30Z

Not entirely related, but do we even need DBI at all anymore? even in suggests?

cjyetman · 2024-04-24T07:44:43Z

Not entirely related, but do we even need DBI at all anymore? even in suggests?

yes, it's required to do the SQLite exports, e.g.

workflow.data.preparation/run_pacta_data_preparation.R

Lines 654 to 670 in 5a96cc3

    
           con <- 
        
             DBI::dbConnect( 
        
               drv = RSQLite::SQLite(), 
        
               dbname = file.path(config[["data_prep_outputs_path"]], "entity_info.sqlite") 
        
             ) 
        
           RSQLite::sqliteSetBusyHandler(con, 3000L) 
        
           dplyr::copy_to( 
        
             dest = con, 
        
             df = entity_info, 
        
             name = "entity_info", 
        
             overwrite = TRUE, 
        
             temporary = FALSE, 
        
             indexes = list("factset_entity_id") 
        
           ) 
        
           DBI::dbDisconnect(con)

jdhoffa · 2024-04-24T07:48:42Z

Got it! Makes sense

Given that we (likely) will want to be able to run the SQLite export using Docker... it seems like we do in fact need that package (and corresponding system) dependency?
Maybe we need to move that to Depends?

Or otherwise just limit SQLite output generation to local run only

cjyetman · 2024-04-24T08:06:41Z

DBI is in Imports. Do you mean move it to Suggests?

workflow.data.preparation/DESCRIPTION

Lines 30 to 32 in 5a96cc3

    
           Imports: 
        
               config, 
        
               DBI,

I thought we had decided that SQLite export should be default for "production" moving forward?

workflow.data.preparation/config.yml

Line 20 in 5a96cc3

    
           export_sqlite_files: TRUE  # a single `TRUE` or `FALSE` specifying whether sqlite versions of some output files should be included in the outputs

Maybe additional R packages that are not technically needed here are already installed in the base image, and the action should be doing this instead?

req_r_pkgs <- sort(unique(pak::pkg_deps(pkg = ".")$package))
pak::sysreqs_check_installed(packages = req_r_pkgs)

jdhoffa · 2024-04-24T08:12:11Z

AH sorry I misunderstood, I thought DBI was in Suggests for THIS repo. But you're saying that the package arrow is in Suggests for DBI, and that's why we are picking it up??

In that case, that sorta seems excessive? I doubt we need the sysdeps of suggested packages of our pkg dependencies here? What do you two think

cjyetman · 2024-04-24T08:18:51Z

AH sorry I misunderstood, I thought DBI was in Suggests for THIS repo. But you're saying that the package arrow is in Suggests for DBI, and that's why we are picking it up??

In that case, that sorta seems excessive? I doubt we need the sysdeps of suggested packages of our pkg dependencies here? What do you two think

Not 100% sure, but it was a suspicion. Have been discussing with pak dev, and it seems like I was wrong. Now I think what is most likely is that arrow is installed in the base image, and because the action is running pak::sysreqs_check_installed(), it's checking for the system dependencies of every installed R package, which is why I'm suggesting to maybe restrict that to...

req_r_pkgs <- sort(unique(pak::pkg_deps(pkg = ".")$package))
pak::sysreqs_check_installed(packages = req_r_pkgs)

i.e. check that the system requirements for only the required (not installed) R packages are installed

jdhoffa · 2024-04-24T08:44:27Z

Indeed you are correct:

cjyetman · 2024-04-24T09:49:44Z

confirmed

with

FROM --platform=linux/amd64 rocker/tidyverse

RUN Rscript -e 'install.packages("pak")'
RUN git clone https://github.com/RMI-PACTA/workflow.data.preparation.git
RUN Rscript -e 'pak::pak("knitr")'

WORKDIR /workflow.data.preparation

# Rscript -e 'pak::sysreqs_check_installed()'
system package       installed required by                      
--------------       --        -----------                      
cmake                ✖         arrow                            
git                  ✔         credentials, gitcreds, remotes   
libcurl4-openssl-dev ✔         arrow, curl                      
libfontconfig1-dev   ✔         systemfonts                      
libfreetype6-dev     ✔         ragg, systemfonts, textshaping   
libfribidi-dev       ✔         textshaping                      
libgit2-dev          ✔         gert                             
libharfbuzz-dev      ✔         textshaping                      
libicu-dev           ✔         stringi                          
libjpeg-dev          ✔         ragg                             
libmysqlclient-dev   ✔         RMariaDB                         
libpng-dev           ✔         ragg                             
libpq-dev            ✔         RPostgres                        
libssl-dev           ✔         arrow, curl, openssl             
libtiff-dev          ✔         ragg                             
libxml2-dev          ✔         xml2                             
make                 ✔         fs, haven, httpuv, sass          
pandoc               ✔         knitr, pkgdown, reprex, rmarkdown
zlib1g-dev           ✔         haven, httpuv                    
# Rscript -e 'req_r_pkgs <- sort(unique(pak::pkg_deps(pkg = ".")$package)); pak::sysreqs_check_installed(packages = req_r_pkgs)'
! Using bundled GitHub PAT. Please add your own PAT using `gitcreds::gitcreds_set()`.
✔ Loading metadata database ... done
system package       installed required by                   
--------------       --        -----------                   
git                  ✔         credentials, gitcreds, remotes
libcurl4-openssl-dev ✔         curl                          
libfontconfig1-dev   ✔         systemfonts                   
libfreetype6-dev     ✔         ragg, systemfonts, textshaping
libfribidi-dev       ✔         textshaping                   
libgit2-dev          ✔         gert                          
libharfbuzz-dev      ✔         textshaping                   
libicu-dev           ✔         stringi                       
libjpeg-dev          ✔         ragg                          
libpng-dev           ✔         ragg                          
libssl-dev           ✔         curl, openssl                 
libtiff-dev          ✔         ragg                          
libxml2-dev          ✔         xml2                          
make                 ✔         fs, httpuv, sass              
pandoc               ✔         knitr, pkgdown, rmarkdown     
zlib1g-dev           ✔         httpuv

jdhoffa · 2024-04-24T09:51:36Z

Was my confirmation insufficient? 😭

cjyetman · 2024-04-24T09:53:30Z

Was my confirmation insufficient? 😭

confirmed that going with this is probably more ideal (and doesn't have the same problem)

req_r_pkgs <- sort(unique(pak::pkg_deps(pkg = ".")$package))
pak::sysreqs_check_installed(packages = req_r_pkgs)

jdhoffa · 2024-04-24T10:02:11Z

Corresponding issue opened here: RMI-PACTA/actions#79

jdhoffa · 2024-04-24T10:02:32Z

Was my confirmation insufficient? 😭

confirmed that going with this is probably more ideal (and doesn't have the same problem)
req_r_pkgs <- sort(unique(pak::pkg_deps(pkg = ".")$package))
pak::sysreqs_check_installed(packages = req_r_pkgs)

lol, i thought you were just being petty because I used a screenshot 😂

cjyetman · 2024-05-01T11:51:10Z

superseded by #228

build(docker): #220 Add standard RMI docker workflow

b1ef431

Closes: #220

AlexAxthelm and others added 12 commits April 17, 2024 13:53

Use JSON notation for CMD

7379992

Use branch of RMI-PACTA/Actions

5f96c3e

Specify build platform in workflow

d6f6a3b

Closes #220

Merge branch 'main' into build/220-add-docker-actions

834ecc5

use main branch of actions

48274a7

remove duplicate build action

c308f3f

Tag base image version

081a0ad

Consolidate RUN commands

c5c743a

use [ extractor rather than $ in pak installation

3933f0e

Do not specify platform in dockerfile

9ac9389

Add system dependency

11d769e

Remove unused build arg

da40f44

AlexAxthelm marked this pull request as ready for review April 17, 2024 14:38

AlexAxthelm requested a review from cjyetman as a code owner April 17, 2024 14:38

cjyetman requested changes Apr 17, 2024

View reviewed changes

Merge branch 'main' into build/220-add-docker-actions

cf2f9b2

AlexAxthelm requested a review from cjyetman April 18, 2024 10:05

Restore forcing build on amd64 platform

42a7931

cjyetman requested a review from jdhoffa April 22, 2024 10:18

Merge branch 'main' into build/220-add-docker-actions

d76aa51

jdhoffa mentioned this pull request Apr 24, 2024

feature: docker-check-R-sysdeps.yml should only check sys deps of dependencies RMI-PACTA/actions#79

Open

jdhoffa mentioned this pull request Apr 27, 2024

use RMI-PACTA/actions/.github/workflows/docker.yml to test build of Docker image #228

Merged

Merge branch 'main' into build/220-add-docker-actions

2992bca

cjyetman closed this May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(docker): #220 Add standard RMI docker workflow #221

build(docker): #220 Add standard RMI docker workflow #221

AlexAxthelm commented Apr 16, 2024

github-actions bot commented Apr 16, 2024 •

edited

Loading

cjyetman commented Apr 16, 2024

AlexAxthelm commented Apr 16, 2024

cjyetman commented Apr 16, 2024

cjyetman left a comment

AlexAxthelm commented Apr 18, 2024

cjyetman commented Apr 18, 2024

AlexAxthelm commented Apr 18, 2024

cjyetman commented Apr 20, 2024

AlexAxthelm commented Apr 23, 2024

cjyetman commented Apr 23, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024 •

edited

Loading

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024 •

edited

Loading

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented May 1, 2024

build(docker): #220 Add standard RMI docker workflow #221

build(docker): #220 Add standard RMI docker workflow #221

Conversation

AlexAxthelm commented Apr 16, 2024

github-actions bot commented Apr 16, 2024 • edited Loading

Docker build status

cjyetman commented Apr 16, 2024

AlexAxthelm commented Apr 16, 2024

cjyetman commented Apr 16, 2024

cjyetman left a comment

Choose a reason for hiding this comment

AlexAxthelm commented Apr 18, 2024

cjyetman commented Apr 18, 2024

AlexAxthelm commented Apr 18, 2024

cjyetman commented Apr 20, 2024

AlexAxthelm commented Apr 23, 2024

cjyetman commented Apr 23, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024 • edited Loading

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024 • edited Loading

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

jdhoffa commented Apr 24, 2024

cjyetman commented May 1, 2024

github-actions bot commented Apr 16, 2024 •

edited

Loading

jdhoffa commented Apr 24, 2024 •

edited

Loading

jdhoffa commented Apr 24, 2024 •

edited

Loading