Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump @redhat-cloud-services/eslint-config-redhat-cloud-services from 1.3.0 to 2.0.3 #340

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 20, 2023

Bumps @redhat-cloud-services/eslint-config-redhat-cloud-services from 1.3.0 to 2.0.3.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@ezr-ondrej
Copy link
Member

@dependabot rebase

Bumps @redhat-cloud-services/eslint-config-redhat-cloud-services from 1.3.0 to 2.0.3.

---
updated-dependencies:
- dependency-name: "@redhat-cloud-services/eslint-config-redhat-cloud-services"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/redhat-cloud-services/eslint-config-redhat-cloud-services-2.0.3 branch from 1ac3f1b to 5a0ce69 Compare January 15, 2024 15:32
@ezr-ondrej
Copy link
Member

It's now quite noisy about Avoid using relative imports from @patternfly/react-<xxx>. Use direct import path to <YYYY>. I suggest not to merge until we decide what to do about those.

My guts tell me I do not like the suggested imports, so I'd just globally silenced'em, but maybe there is some merit, so we should discuss it first :)

@amirfefer
Copy link
Member

agree, noisy warning, which telling developers to avoid that kind of importing, or using treeshaking like we did.
but we can globally silence it.

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 29, 2024

Superseded by #401.

@dependabot dependabot bot closed this Mar 29, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/redhat-cloud-services/eslint-config-redhat-cloud-services-2.0.3 branch March 29, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants