chore: update to Go 1.20, oapi-gen/v2 and deps #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Zapletal <[email protected]>
lzap
commented
Nov 7, 2023
| github.com/twmb/murmur3 v1.1.8 // indirect | ||
| github.com/ugorji/go/codec v1.2.11 // indirect | ||
| github.com/valyala/bytebufferpool v1.0.0 // indirect | ||
| github.com/valyala/fasttemplate v1.2.2 // indirect |
There was a problem hiding this comment.
Many of dependencies dropped because of openapi-gen changes (echo and its subdependencies).
lzap
commented
Nov 7, 2023
| @@ -17,7 +17,7 @@ imports: ## Rearrange imports using `goimports` | |||
|
|
|||
| .PHONY: lint | |||
| lint: ## Run Go language linter `golangci-lint` | |||
| GOROOT=$(GOROOT) PATH=$(GOROOT)/bin:${PATH} GOCACHE=$(GOCACHE) $(GOLINT) run | |||
| GOROOT=$(GOROOT) PATH=$(GOROOT)/bin:${PATH} GOCACHE=$(GOCACHE) $(GOLINT) run --path-prefix $(shell pwd) | |||
There was a problem hiding this comment.
This prefix files with absolute patch which makes the output "clickable" in GoLand directly.
|
So the newer linter is again more strict, bunch of refactoring:
|
ezr-ondrej
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big update since Go 1.20 is live on ubi9, this allows us to unpin oapi-gen and finally upgrade to v2 which drops ton of dependencies because they have broken down the project into subprojects. I had to regenerate all OpenAPI clients too. Finally, updated all tools and deps to test it out.