Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable arm64 on AWS #723

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat: enable arm64 on AWS #723

merged 1 commit into from
Oct 23, 2023

Conversation

ezr-ondrej
Copy link
Member

@ezr-ondrej ezr-ondrej commented Oct 17, 2023

This should enable arm64, it's not perfect for sure, but at least there's a test! 😛

Refs HMS-1135

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nickpick, nice.

internal/clients/http/errors.go Outdated Show resolved Hide resolved
internal/services/aws_reservation_service.go Show resolved Hide resolved
Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tests are failing tho.

Verifies the image is built for the right architecture with image builder.

Refs HMS-2818
@ezr-ondrej
Copy link
Member Author

Ok, tests are failing tho.

it was an regression! 🤦 Fixed :)

@lzap lzap merged commit 94038e9 into RHEnVision:main Oct 23, 2023
6 checks passed
@lzap
Copy link
Member

lzap commented Oct 23, 2023

Thanks.

@ezr-ondrej ezr-ondrej deleted the support_arm branch October 23, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants