Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update deps #722

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore: update deps #722

merged 1 commit into from
Oct 23, 2023

Conversation

lzap
Copy link
Member

@lzap lzap commented Oct 17, 2023

Hopefully resolves GHSA-rcjv-mgp8-qvmr

Had to pin two dependencies because of 1.19 incompatibility already.

@lzap
Copy link
Member Author

lzap commented Oct 17, 2023

Will fix:

internal/telemetry/otel.go:13:2: SA1019: "go.opentelemetry.io/otel/exporters/jaeger" is deprecated: This module is no longer supported. OpenTelemetry dropped support for Jaeger exporter in July 2023. Jaeger officially accepts and recommends using OTLP. Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp] or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead. (staticcheck)

@lzap lzap mentioned this pull request Oct 18, 2023
Merged
@lzap
Copy link
Member Author

lzap commented Oct 18, 2023

Fixing Jaeger deprecation in another PR, then I will rebase this one on top of that.

@ezr-ondrej
Copy link
Member

Is this ready for rebase? :)

@lzap
chore: update deps
2b48186 
Signed-off-by: Lukas Zapletal <[email protected]>
@lzap
Copy link
Member Author

lzap commented Oct 23, 2023

Rebased.

ezr-ondrej
ezr-ondrej approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzap ! 👍

@ezr-ondrej ezr-ondrej merged commit 567f12b into RHEnVision:main Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezr-ondrej ezr-ondrej ezr-ondrej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzap @ezr-ondrej