Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add otel pgx parameters to log #715

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

lzap
Copy link
Member

@lzap lzap commented Oct 12, 2023

We do not include slices in our telemetry2zerolog implementation, the otelpgx library does use string slice for params. This was the reason why it was missing. This fixes it.

Copy link
Member

@avitova avitova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@avitova avitova merged commit b84a0dc into RHEnVision:main Oct 12, 2023
6 checks passed
@lzap lzap deleted the otel-params branch October 12, 2023 13:01
@lzap
Copy link
Member Author

lzap commented Oct 12, 2023

Thanks, I do have a small followup :-D

@avitova
Copy link
Member

avitova commented Oct 12, 2023

Happy to hear that:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants