Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Priv ip aws #698

Closed
wants to merge 2 commits into from
Closed

Conversation

ezr-ondrej
Copy link
Member

Thanks for the contribution, make sure your commit message follows this subject style:

    type: brief summary up to 70 characters or
    type(scope): brief summary up to 70 characters

Type is required, scope is optional. Prefer lower-case and avoid dot at the end.

Find more info about types and scopes at:

https://github.com/RHEnVision/provisioning-backend#contributing

Take a moment to read our contributing and security guidelines:

https://github.com/RedHatInsights/secure-coding-checklist

Checklist

  • all commit messages follows the policy above
  • the change follows our security guidelines

@lzap
Copy link
Member

lzap commented Oct 6, 2023

Sorry I just rebased, was finishing other work :)

@ezr-ondrej
Copy link
Member Author

Sorry I just rebased, was finishing other work :)

No biggie :) I just wanted to find out... I've checked out your changes anyway to work on Azure follow-up :)

@lzap
Copy link
Member

lzap commented Oct 6, 2023

Now we have "iqe_provisioning.ApplicationProvisioningNotFoundException: Cannot find reservation within context to resolve getattr for instances" I think we need an IQE refresh either way.

@akhil-jha
Copy link
Member

I don't think you need this PR anymore :)

@lzap
Copy link
Member

lzap commented Oct 9, 2023

Merged the AWS PR now.

@ezr-ondrej
Copy link
Member Author

Of course, closing, sorry for leaving it hanging for so long :)

@ezr-ondrej ezr-ondrej closed this Oct 19, 2023
@ezr-ondrej ezr-ondrej deleted the priv-ip-aws branch October 19, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants