fix(HMS-1847): Adding configmap to job #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurilahane
force-pushed
the
mlahane/mount_configmap
branch
from
111b764 to
64dd5d1
Compare
mayurilahane
changed the title
mayurilahane
force-pushed
the
mlahane/mount_configmap
branch
from
64dd5d1 to
b00146f
Compare
mshriver
reviewed
Oct 3, 2023
deploy/cloudwash_job.yaml
Outdated
| - name: config-volume | ||
| configMap: | ||
| name: cloudwash-config | ||
| envFrom: |
There was a problem hiding this comment.
This block shouldn't be necessary, the expected configmap is getting subPath mounted
There was a problem hiding this comment.
I removed the config map block only
did you mean the whole volume block?
There was a problem hiding this comment.
just the envFrom map - but the volumes map is out of place too, its not part of Container spec, only volumeMounts. volumes is part of the Pod spec, that map starts at L20.
mayurilahane
force-pushed
the
mlahane/mount_configmap
branch
from
b00146f to
dab55af
Compare
mayurilahane
changed the title
mayurilahane
force-pushed
the
mlahane/mount_configmap
branch
from
dab55af to
212e189
Compare
|
/retest |
mshriver
reviewed
Oct 11, 2023
| volumeMounts: | ||
| - name: config-volume | ||
| mountPath: /opt/app-root/src/cloudwash/settings.yaml | ||
| subPath: settings.yaml |
There was a problem hiding this comment.
suspect of this config with mountPath having the file, but I'm going to accept at this point to run in SRE cluster.
mshriver
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For adding config maps into a job:
3. Now have added its mount point in this MR's job file