-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electrum support #131
Merged
Merged
Add electrum support #131
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
328dcae
resolver: rename esplora into esplora_blocking and do a dedicated mod
dr-orlovsky ca2b84d
add electrum Resolver
zoedberg e5422be
fix electrum Resolver
zoedberg 8b027ac
add AnyResolver
zoedberg 2c0e3ea
WASM fixes.
cryptoquick b3b083f
Switch to patching bp-wallet 0.11 branch.
cryptoquick 85b8edd
chore: update dependencies
dr-orlovsky 84fdff0
chore: update dependencies
dr-orlovsky ce03e36
chore: fix feature flag composition
dr-orlovsky 6b692ed
Merge branch 'electrum' into HB/wasm
dr-orlovsky ac5c2b9
Merge pull request #132 from cryptoquick/HB/wasm
dr-orlovsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
feature: | ||
- esplora | ||
- esplora_blocking | ||
- log | ||
- serde | ||
steps: | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
// RGB smart contracts for Bitcoin & Lightning | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
// Written in 2024 by | ||
// Zoe Faltibà <[email protected]> | ||
// | ||
// Copyright (C) 2024 LNP/BP Standards Association. All rights reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use rgbstd::resolvers::ResolveHeight; | ||
use rgbstd::validation::{ResolveWitness, WitnessResolverError}; | ||
use rgbstd::{WitnessAnchor, WitnessId, XAnchor, XPubWitness}; | ||
|
||
#[cfg(feature = "electrum")] | ||
use crate::electrum; | ||
#[cfg(feature = "esplora_blocking")] | ||
use crate::esplora_blocking; | ||
|
||
/// Type that contains any of the [`Resolver`] types defined by the library | ||
#[derive(From)] | ||
#[non_exhaustive] | ||
pub enum AnyResolver { | ||
#[cfg(feature = "electrum")] | ||
#[from] | ||
/// Electrum resolver | ||
Electrum(Box<electrum::Resolver>), | ||
#[cfg(feature = "esplora_blocking")] | ||
#[from] | ||
/// Esplora resolver | ||
Esplora(Box<esplora_blocking::Resolver>), | ||
} | ||
|
||
#[allow(clippy::large_enum_variant)] | ||
#[derive(Debug, Display, Error, From)] | ||
#[display(doc_comments)] | ||
pub enum AnyAnchorResolverError { | ||
#[cfg(feature = "electrum")] | ||
#[from] | ||
#[display(inner)] | ||
Electrum(electrum::AnchorResolverError), | ||
#[cfg(feature = "esplora_blocking")] | ||
#[from] | ||
#[display(inner)] | ||
Esplora(esplora_blocking::AnchorResolverError), | ||
} | ||
|
||
impl ResolveHeight for AnyResolver { | ||
type Error = AnyAnchorResolverError; | ||
|
||
fn resolve_anchor(&mut self, anchor: &XAnchor) -> Result<WitnessAnchor, Self::Error> { | ||
match self { | ||
#[cfg(feature = "electrum")] | ||
AnyResolver::Electrum(inner) => inner.resolve_anchor(anchor).map_err(|e| e.into()), | ||
#[cfg(feature = "esplora_blocking")] | ||
AnyResolver::Esplora(inner) => inner.resolve_anchor(anchor).map_err(|e| e.into()), | ||
} | ||
} | ||
} | ||
|
||
impl ResolveWitness for AnyResolver { | ||
fn resolve_pub_witness( | ||
&self, | ||
witness_id: WitnessId, | ||
) -> Result<XPubWitness, WitnessResolverError> { | ||
match self { | ||
#[cfg(feature = "electrum")] | ||
AnyResolver::Electrum(inner) => inner.resolve_pub_witness(witness_id), | ||
#[cfg(feature = "esplora_blocking")] | ||
AnyResolver::Esplora(inner) => inner.resolve_pub_witness(witness_id), | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zoedberg,
Please set
default-features=false
, to avoid load bp-esplora blocking client along wasm compilation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @crisdut, sorry for the late answer but I've somehow missed this. Thanks for the tip, unfortunately though I'm still receiving the previously reported errors.