bp-wallet default-features false

[zoedberg]

By adding bp-wallet to the dependencies without specifying default-features = false we are also importing bp-esplora (because bp-wallet specifies default = ["esplora"]), making the rgb-runtime definition of the esplora feature (esplora = ["bp-esplora", "bp-wallet/esplora"]) pointless.
With this PR we import bp-wallet without default features, allowing users of rgb-runtime to avoid depending on bp-esplora unconditionally.

[dr-orlovsky]

Thank you for figuring this out. I think the right way to fix the issue is to remove esplora from default features in bp-wallet. I did this here: BP-WG/bp-wallet@9d1cf14

What do you think?

[dr-orlovsky]

BTW this is duplicate of #127

[zoedberg]

I was not sure it was correct removing esplora from the default features of bp-wallet, but this also does the trick so LGTM, thanks

[dr-orlovsky]

removing esplora from the default features of bp-wallet

I think it was a mistake it got there first: bp-wallet is assumed to be a library. Originally it was a cli and that's why it needed default feature so users can do cargo install bp-wallet without --all-features (which always confuses people, who do not read README and leads to plenties of opened issue saying the same thing "this does not compile!" over and over again). But since it is library, and the cli name is bp-util, it was safe to remove it there