Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch between blank builders and their inputs #289

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

dr-orlovsky
Copy link
Member

Closes #284

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Jan 6, 2025
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jan 6, 2025
@dr-orlovsky dr-orlovsky requested review from zoedberg and St333p January 6, 2025 13:10
@dr-orlovsky dr-orlovsky self-assigned this Jan 6, 2025
@dr-orlovsky dr-orlovsky changed the title persistence: fix mismatch between blank builders and their inputs Fix mismatch between blank builders and their inputs Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 18.4%. Comparing base (b374468) to head (14ca8d8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/persistence/stock.rs 0.0% 11 Missing ⚠️
src/containers/partials.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #289     +/-   ##
========================================
- Coverage    18.4%   18.4%   -0.0%     
========================================
  Files          38      38             
  Lines        8705    8706      +1     
========================================
  Hits         1598    1598             
- Misses       7107    7108      +1     
Flag Coverage Δ
rust 18.4% <0.0%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky merged commit 14ca8d8 into master Jan 7, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Blank transition fails to construct when multiple close methods are involved
2 participants