Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API sanation for state types #200

Merged
merged 7 commits into from
Jan 19, 2024
Merged

API sanation for state types #200

merged 7 commits into from
Jan 19, 2024

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Jan 7, 2024

  • Add blinding to data types
  • Make function names and signatures working with blinding factors more consistent
  • Separate state which contains blinding information from the state which doesn't
  • Provide a trait for non-blinded state (KnownState)

Prerequisite for RGB-WG/rgb-std#126 and RGB-WG/rgb#92

@dr-orlovsky dr-orlovsky added refactoring Code refactoring *compatibility* Issues affecting compatibility and interoperability labels Jan 7, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jan 7, 2024
@dr-orlovsky dr-orlovsky added the *consensus* Issues affecting distributed concensus label Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (c627404) 16.9% compared to head (2b59903) 16.7%.

Files Patch % Lines
src/contract/data.rs 9.1% 30 Missing ⚠️
src/contract/contract.rs 4.2% 23 Missing ⚠️
src/contract/attachment.rs 0.0% 13 Missing ⚠️
src/vm/op_contract.rs 0.0% 5 Missing ⚠️
src/validation/logic.rs 0.0% 1 Missing ⚠️
src/validation/state.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #200     +/-   ##
========================================
- Coverage    16.9%   16.7%   -0.2%     
========================================
  Files          32      32             
  Lines        3827    3874     +47     
========================================
- Hits          647     646      -1     
- Misses       3180    3228     +48     
Flag Coverage Δ
rust 16.7% <12.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky merged commit 729c652 into master Jan 19, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*compatibility* Issues affecting compatibility and interoperability *consensus* Issues affecting distributed concensus refactoring Code refactoring
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants