Feature/basemaps #67
Merged
Feature/basemaps #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
seeing this console.error() in observation-chart.js:26
it seems to be occurring whenever the "USGS imagery topo" or "cartoDB-Positron" base layers are selected.
MUI: A component is changing the default value state of an uncontrolled RadioGroup after being initialized. To suppress this warning opt to use a controlled RadioGroup.
PhillipsOwen
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this new feature to select a basemap for the UI. I have just added 3 basemap's for now, but easy to add more in the future. The basemap list is in utils/map-utils.js
The selected basemap is persisted in local storage, so the user will get the same basemap with refresh of the website.
I am not aware of any bugs in this feature, and it is mostly complete, except that it currently does not support dark mode. I have created issue #66 for discussion about how to support dark mode.
After merging this branch can be removed.