Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy react #59

Merged
merged 4 commits into from
May 22, 2024
Merged

tidy react #59

merged 4 commits into from
May 22, 2024

Conversation

mbwatson
Copy link
Member

@mbwatson mbwatson commented May 22, 2024 •
edited
Loading

the layer logic seems sensible. i took the liberty to tidy up some of the jsx and some of the styles.

@mbwatson mbwatson requested a review from lstillwe May 22, 2024 18:50
lstillwe
lstillwe requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up my styling - I can close one of my issues now. :)
I think there are a couple of issues here.

  1. Near line 26 in control-panel.js - you forgot to include MaxElevationIcon
  2. Line 209 in control-pane.js - ‘instncae_name’ is spelled incorrectly

@mbwatson
Copy link
Member Author

thanks. on it!

@mbwatson mbwatson requested a review from lstillwe May 22, 2024 19:17
lstillwe
lstillwe approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!
Looks good.

@lstillwe lstillwe merged commit 9effe9d into feature/control-panel May 22, 2024
@lstillwe lstillwe deleted the feature/control-panel-mw branch May 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstillwe lstillwe lstillwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbwatson @lstillwe