Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermediate PR: Additional model search functionality #58

Merged
merged 23 commits into from
May 22, 2024
Merged

Intermediate PR: Additional model search functionality #58

merged 23 commits into from
May 22, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

just want to get this into main for demo purposes tomorrow. note the latest main was merged into this branch.

Also, Please do not remove the branch.

PhillipsOwen added 22 commits May 16, 2024 17:00
@PhillipsOwen
addition of mui datepicker and day.js
46cf7ec
@PhillipsOwen
tidying up
d320fe3
@PhillipsOwen
checkpointing progress
0157cfc
@PhillipsOwen
moving the tanstack query clien/provider from the obs dialog to the r…
ce98b41 
…oot of the app.
@PhillipsOwen
Merge remote-tracking branch 'origin/model-selection-data' into model…
a798343 
…-selection-data
@PhillipsOwen
renaming main view of the model selection tray
460aa82
@PhillipsOwen
renaming model selection tray
ad2d965
@PhillipsOwen
component to create dropdown options from web service data
ba2652c
@PhillipsOwen
component to render the synoptic model selection tab
0e93d37
@PhillipsOwen
component to render the tropical model selection tab
f162a94
@PhillipsOwen
adding control to render search results.
13dd932
@PhillipsOwen
adding additional error checking
76a3ab5
@PhillipsOwen
adding the retrieval and rendering of search results.
609adb0
@PhillipsOwen
renaming main view of the model selection tray
c4c9126
@PhillipsOwen
renaming model selection tray
673da85
@PhillipsOwen
component to create dropdown options from web service data
34d5629
@PhillipsOwen
component to render the synoptic model selection tab
9fee14c
@PhillipsOwen
component to render the tropical model selection tab
ac122d9
@PhillipsOwen
adding control to render search results.
8b88f44
@PhillipsOwen
adding additional error checking
e1cdce7
@PhillipsOwen
adding the retrieval and rendering of search results.
81af940
@PhillipsOwen
Merge remote-tracking branch 'origin/model-selection-data' into model…
c43dc67 
…-selection-data
@PhillipsOwen PhillipsOwen requested review from lstillwe and mbwatson May 22, 2024 17:16
lstillwe
lstillwe approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - making good progress. I am sure you will address this in the future, but just thought I should point out, that if you just select a date of the synoptic tab. The returned data should be grouped by model run date and cycle.
Screenshot 2024-05-22 at 1 38 41 PM

@PhillipsOwen
Copy link
Collaborator Author

PhillipsOwen commented May 22, 2024 •
edited
Loading

lisa,

i checked the V2 version of this and it is returning the same data if only a date is selected. if you want grouping by cycle one has to select one.

mbwatson
mbwatson approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mbwatson mbwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is coming along nicely!

@mbwatson mbwatson merged commit 69d88ff into main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbwatson mbwatson mbwatson approved these changes

@lstillwe lstillwe lstillwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhillipsOwen @lstillwe @mbwatson