generated from RENCI/react-starter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/layer actions #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add up/down buttons to layer cards add adjacent swap ordering buttons to layers add layer move and delete actions
use small expand button
fix move button flex minor styling remove comment
align inconsistent indentation
we don't keep expanded cards in state any longer.
cleanup cleanup
lstillwe
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR brings in a changes to layer cards in the layers tray. the data rendered in the card itself is tidied up (not sure it's what we ultimately want, but a step in the right direction in terms of less clutter) and action buttons are introduced for metadata, opacity, color ramp, delete layer. layer reordering is also implemented, although not via drag-and-drop for the sake of simplicity for now.
this PR also comes with setting up theming and a dark mode toggle in settings. i created a couple styles in mapbox studio for simple light and dark basemaps. of course, we can customize later. in order to utilize the MapBox API, i've added a
MAPBOX_TOKEN
env var.