Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#91 Date picker error handling #168

Merged
merged 6 commits into from
Aug 16, 2024
Merged

#91 Date picker error handling #168

merged 6 commits into from
Aug 16, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

@PhillipsOwen PhillipsOwen commented Aug 14, 2024

Added a bunch of code (after a bunch of investigation/testing) to handle the calendar control validation.

note that the previous UI did not allow manually entering dates, this one does. so there a lot more test conditions to go through.

if you find a error please take note of the steps to reproduce and let me know. i am still finding issues as i continue my testing. there are a number of console.log() statements (that are commented out) that may help in troubleshooting.

@PhillipsOwen PhillipsOwen marked this pull request as draft August 15, 2024 11:36
@PhillipsOwen PhillipsOwen marked this pull request as ready for review August 15, 2024 14:28
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a lot of new code!
Looks good to me - I didn't find any bugs. If you are still aware of some bugs, please create some issues so we can keep track. Thanks!

@lstillwe lstillwe merged commit 2fd73b1 into main Aug 16, 2024
@PhillipsOwen PhillipsOwen deleted the #91-date-picker-reset branch August 19, 2024 13:40
@PhillipsOwen PhillipsOwen removed the request for review from mbwatson August 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants