Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#56-Remove selected observation data from state #166

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

PhillipsOwen
Copy link
Collaborator

addresses #56

when the observations are toggled on the control panel, all open obs dialogs and "target" overlays are removed.

@PhillipsOwen PhillipsOwen requested a review from lstillwe August 13, 2024 20:40
@PhillipsOwen
Copy link
Collaborator Author

i refactored the code that removes selected observations to the more common map context area.

this also included going over the app and added the call to remove selected observations where it made sense.

this PR is ready for another review pass.

@PhillipsOwen PhillipsOwen changed the title Remove observation data from state #56-Remove selected observation data from state Aug 15, 2024
Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks comprehensive!

@lstillwe lstillwe merged commit f06fb46 into main Aug 16, 2024
@lstillwe lstillwe deleted the #56-remove-obs-dialogs branch August 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants