-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes before the release #152
Conversation
Bachibouzouk
commented
Jun 5, 2024
•
edited
Loading
edited
- fix the conversion from .py to .xlsx
- fix the link to contribution.html
- fix test_run.py
- fix unexpected warning on appliances with duty cycles
Contributing.html is browsable locally with the docs but somehow not online, I need to have a closer look at it, somehow commiting the .md file did not solve the issue |
Hi, I've pushed a commit that fixes the path issues in Nonetheless, in implementing such a fix, I bumped into other small issues. Namely, I get the following warning for all three input files: The warning poses 2 issues:
|
The app name seem to be "", now I added a default name when an appliance gets added to a user in #153 (specifically 522b436) |
I found the following comment in the code
|
@FLomb - the warning was actually showing some odd behavior which was swept under the rug before, see #153 (it does not modify tremenduously the example profiles, fortunately :)) |
Previously the mean of the index range was computed and see if it was falling within a duty cycle. This method compare the boundaries of the range with the one of each duty cycle to know if there is an intersection. If there is one, the duty cycle is chosen. Note: this method does not take into account the case where the indexes range spans accross more than one duty cycle.
Fix duty cycle selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested extensively the PR locally, and all seems to work very smoothly. I am happy to approve it. Thanks, @Bachibouzouk !