Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component as function call #7061

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Nov 13, 2024

Return a function with the SERIALIZABLE_STATE as a _jsxSplit type to process function call as a component$

@Varixo Varixo requested a review from a team as a code owner November 13, 2024 15:51
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: c9e6b71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7061
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7061
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7061
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7061

commit: c9e6b71

Copy link
Contributor

github-actions bot commented Nov 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c9e6b71

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens
Copy link
Member

@Varixo this can be merged right? I seem to recall that there was some question about it?

@Varixo Varixo merged commit d533e19 into build/v2 Nov 15, 2024
19 checks passed
@Varixo Varixo deleted the fix-component-as-func-case-2 branch November 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants