Improved performance of harvest list page

[hudson-newey]

Improve performance of harvest list page

The harvest list page sends two requests and requests a lot of redundant information

Changes

• The Harvest list page now only requests the subset of harvest properties it needs
• our custom pagination.directive.ts now only makes one request (this fixes double requests on any page that uses this directive)
• Adds tests for all changes
• Fixes typos

Problems

Na

Issues

Fixes: #2045

Visual Changes

Na

TODO

Measure the performance increase (expecting >200%)

Final Checklist

• Assign reviewers if you have permission
• Assign labels if you have permission
• Link issues related to PR
• Ensure project linter is not producing any warnings (npm run lint)
• Ensure build is passing on all browsers (npm run test:all)
• Ensure CI build is passing
• Ensure docker container is passing (docs)

[github-actions]

Size Change: -1 B (0%)

Total Size: 3.45 MB

Filename	Size	Change
dist/workbench-client/browser/index.html	3.83 kB	-1 B (0%)
dist/workbench-client/browser/main.****************.js	1.15 MB	+12 B (0%)
dist/workbench-client/server/main.js	2.25 MB	-12 B (0%)

ℹ️ View Unchanged

Filename	Size
dist/workbench-client/browser/assets/environment.json	555 B
dist/workbench-client/browser/manifest.json	150 B
dist/workbench-client/browser/polyfills.****************.js	12.5 kB
dist/workbench-client/browser/runtime.****************.js	715 B
dist/workbench-client/browser/styles.****************.css	37.4 kB

_{compressed-size-action}

[github-actions]

Unit Test Results

         6 files           6 suites   14m 43s ⏱️
20 640 tests 20 010 ✔️ 630 💤 0 ❌
20 748 runs  20 118 ✔️ 630 💤 0 ❌

Results for commit 271c553.

♻️ This comment has been updated with latest results.

[hudson-newey]

Executive summary: little to no improvement in DOM rendering & print times, however 73x less data being transferred (on staging) project "aaaaaaa" which will result in faster loading times and a better user experience

Current master Performance Profile:
https://share.firefox.dev/45oKxOR

With performance improvements:
https://share.firefox.dev/3ZSsU8M

Current data transferred (in ngx-datatable requests): 458.3 kB
Data transferred (in ngx-datatable requests) with performance improvement: 6.26 kB

---

Test conditions:
Staging API using project aaaaaaa with hard reload + clear cache

I used the development master branch and harvest-perf branches so that both tests would use the same build configuration / optimization rules

[atruskie]

good job