Add missing item mappings #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oddly enough, after looking into it, it seems to have only broken between |
supersaiyansubtlety
requested changes
Jan 5, 2025
dead brain, more like brain dead Co-authored-by: Will <[email protected]>
supersaiyansubtlety
approved these changes
Jan 5, 2025
|
really sorry i didn't catch earlier that you wanted to work on this, it's an issue that iota and i previously encountered and fixed in the backend. since enigma/plugin versions are usually only updated on the latest branch, the fixes did not come back to 1.21.1. as we don't like putting in redundant mappings, i'll be superceding this PR with an enigma/plugin update. again, i'm really sorry i didn't get a chance to tell you we had already fixed our automapping! |
ix0rai
added
t: new
|
superseded by #682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix many mappings for items in
Itemsthat were missing.