Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'overrides final method' error #672

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix 'overrides final method' error #672

merged 2 commits into from
Dec 4, 2024

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Dec 4, 2024 •
edited
Loading

Fixes this error which occurs on launch when using 1.21.4-build.1:

java.lang.IncompatibleClassChangeError: class net.minecraft.entity.InteractionEntity overrides final method net.minecraft.entity.Entity.getHeight()F

@supersaiyansubtlety supersaiyansubtlety added bug something isn't working correctly v: release targets a release version of minecraft critical a critical PR; bypasses final comment period s: tiny PRs with less than 50 lines labels Dec 4, 2024
@supersaiyansubtlety supersaiyansubtlety self-assigned this Dec 4, 2024
ix0rai
ix0rai reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the corresponding fields (f_luxekrhz and f_rmbogufh) be updated as well?

@supersaiyansubtlety
Copy link
Member Author

should the corresponding fields (f_luxekrhz and f_rmbogufh) be updated as well?

arguably, but their keys are just "width" and "height"

I think it's fine either way, what's your preference?

@ix0rai
Copy link
Member

ix0rai commented Dec 4, 2024

personally, we should update the field names but not the key fields

ix0rai
ix0rai approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging after checks!

@ix0rai ix0rai merged commit 3348c94 into QuiltMC:1.21.4 Dec 4, 2024
1 check passed
@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels
bug something isn't working correctly critical a critical PR; bypasses final comment period s: tiny PRs with less than 50 lines v: release targets a release version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersaiyansubtlety @ix0rai