Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components and Codecs #664

Merged
merged 20 commits into from
Nov 20, 2024
Merged

Components and Codecs #664

merged 20 commits into from
Nov 20, 2024

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Nov 16, 2024 •
edited
Loading

Mostly completes n/m/components.
Completes Codecs and n/m/network/codec, along with some other codec classes.
Also some misc. things.

@supersaiyansubtlety supersaiyansubtlety added t: new adds new mappings v: snapshot targets a snapshot version of minecraft wip this is a work in progress s: medium PRs with less than 700 lines and more than 200 labels Nov 16, 2024
@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 16, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 24w46a

@github-actions github-actions bot changed the base branch from 24w45a to 24w46a November 19, 2024 01:02
@github-actions GitHub Actions
Copy link
Contributor

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot added outdated this pull request hasn't been updated to the latest version or has merge conflicts and removed update-base used to notify github actions that the base branch should be updated labels Nov 19, 2024
@supersaiyansubtlety
rename cand complete PacketPositionCodec -> PositionSync
2ce4b87 
complet Entity and a few entity-related classes
@supersaiyansubtlety supersaiyansubtlety added s: large PRs with more than 700 lines and removed outdated this pull request hasn't been updated to the latest version or has merge conflicts s: medium PRs with less than 700 lines and more than 200 labels Nov 19, 2024
@supersaiyansubtlety supersaiyansubtlety force-pushed the components-and-codecs branch 2 times, most recently from f406716 to cdc3a69 Compare November 19, 2024 20:52
@supersaiyansubtlety supersaiyansubtlety added reviews needed please review this PR and removed wip this is a work in progress labels Nov 19, 2024
@supersaiyansubtlety supersaiyansubtlety marked this pull request as ready for review November 19, 2024 20:59
@supersaiyansubtlety supersaiyansubtlety added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Nov 19, 2024
@ix0rai ix0rai self-requested a review November 20, 2024 02:21
ix0rai
ix0rai approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just a couple nitpicks!

mappings/net/minecraft/component/type/AttributeModifiersComponent.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/component/type/AttributeModifiersComponent.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/component/type/CustomModelDataComponent.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/util/dynamic/Codecs.mapping Outdated Show resolved Hide resolved
supersaiyansubtlety and others added 3 commits November 20, 2024 05:33
@supersaiyansubtlety @ix0rai
rename param i -> index
e37cb03 
Co-authored-by: ix0rai <[email protected]>
@supersaiyansubtlety @ix0rai
rename forEachModifierOfSlot(s) -> forEachModifier
247a1e1 
Co-authored-by: ix0rai <[email protected]>
@supersaiyansubtlety
rename "single" things -> "individual"
128f175 
improve lambda param names for lambdas in createCodecForPairObject
@supersaiyansubtlety supersaiyansubtlety merged commit 4e7651b into QuiltMC:24w46a Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

@OroArmor OroArmor OroArmor approved these changes

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels
final-comment-period is approved and will soon be merged if no issues are raised s: large PRs with more than 700 lines t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersaiyansubtlety @OroArmor @ix0rai