-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve movement terminology #654
Merged
ix0rai
merged 5 commits into
QuiltMC:1.21.3
from
supersaiyansubtlety:improve-movement-terminology
Nov 4, 2024
Merged
improve movement terminology #654
ix0rai
merged 5 commits into
QuiltMC:1.21.3
from
supersaiyansubtlety:improve-movement-terminology
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersaiyansubtlety
added
t: refactor
proposes a refactor
v: snapshot
targets a snapshot version of minecraft
reviews needed
please review this PR
s: tiny
PRs with less than 50 lines
labels
Oct 13, 2024
ix0rai
added
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 17, 2024
🚀 Target branch has been updated to 1.21.2-pre5 |
github-actions
bot
removed
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 17, 2024
ix0rai
added
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 17, 2024
🚀 Target branch has been updated to 1.21.2-rc1 |
github-actions
bot
removed
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 17, 2024
ix0rai
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
ix0rai
added
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 22, 2024
🚀 Target branch has been updated to 1.21.2 |
github-actions
bot
removed
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 22, 2024
ix0rai
added
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 23, 2024
🚀 Target branch has been updated to 1.21.3 |
github-actions
bot
removed
the
update-base
used to notify github actions that the base branch should be updated
label
Oct 23, 2024
OroArmor
approved these changes
Oct 28, 2024
ix0rai
added
final-comment-period
is approved and will soon be merged if no issues are raised
and removed
reviews needed
please review this PR
labels
Oct 29, 2024
supersaiyansubtlety
added
v: release
targets a release version of minecraft
and removed
v: snapshot
targets a snapshot version of minecraft
labels
Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
final-comment-period
is approved and will soon be merged if no issues are raised
s: tiny
PRs with less than 50 lines
t: refactor
proposes a refactor
v: release
targets a release version of minecraft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename "movement speed" things -> "acceleration factor"
They're used to calculate the vector added to velocity:
Also, it didn't make sense for higher
slipperiness
to reduce the result of this method (formerly namedgetMovementSpeed
):... but it does make sense for
slipperiness
to reduce acceleration.