Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix method conflict in RegistrySetBuilder #651

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix method conflict in RegistrySetBuilder #651

merged 1 commit into from
Oct 9, 2024

Conversation

orifu
Copy link
Contributor

@orifu orifu commented Oct 9, 2024

the private method get in the anonymous class defined in RegistrySetBuilder#buildProvider conflicted with the method get in an implemented interface HolderProvider.Provider. this changes the name to getEntry (from mojmap).

@ix0rai ix0rai added bug something isn't working correctly t: refactor proposes a refactor v: snapshot targets a snapshot version of minecraft critical a critical PR; bypasses final comment period s: tiny PRs with less than 50 lines labels Oct 9, 2024
@ix0rai ix0rai merged commit 5c1ad74 into QuiltMC:1.21.2-pre1 Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
bug something isn't working correctly critical a critical PR; bypasses final comment period s: tiny PRs with less than 50 lines t: refactor proposes a refactor v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orifu @supersaiyansubtlety @ix0rai