Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named methods in CreeperEntity and World. #646

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Named methods in CreeperEntity and World. #646

merged 2 commits into from
Oct 9, 2024

Conversation

HyperPigeon
Copy link
Contributor

  • Mapped public boolean method in CreeperEntity to isCharged.
  • Mapped multiple public void methods in World to createExplosion.

@HyperPigeon
- Mapped public boolean method in CreeperEntity to isCharged.
4774657 
- Mapped multiple public void methods in `World` to `createExplosion`.
@supersaiyansubtlety supersaiyansubtlety added t: new adds new mappings v: snapshot targets a snapshot version of minecraft reviews needed please review this PR s: tiny PRs with less than 50 lines labels Oct 7, 2024
@supersaiyansubtlety
Copy link
Member

Actually, maybespawnExplosion instead?
createExplosion sounds like it would return an Explosion instance.

@HyperPigeon
Copy link
Contributor Author

Actually, maybespawnExplosion instead? createExplosion sounds like it would return an Explosion instance.

That makes a lot of sense. I'll update the mappings.

@OroArmor OroArmor added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Oct 8, 2024
@OroArmor OroArmor merged commit df0ace1 into QuiltMC:24w40a Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OroArmor OroArmor OroArmor approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: tiny PRs with less than 50 lines t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HyperPigeon @supersaiyansubtlety @OroArmor