vmupdate: fix waiting for the other apt-get process #175
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 10 10
Lines 1157 1157
=======================================
Hits 845 845
Misses 312 312 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025010617-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable tests
|
marmarek
force-pushed
the
apt-wait2
branch
3 times, most recently
from
a17a6f2 to
095b382
Compare
apt-get uses fcntl F_SETLK for locking, not flock(). Update the function accordingly. Fixes: 8fa2929 "vmupdate: wait for other apt-get to complete"
"apt-get update" doesn't support waiting for other instances to finish, it exits immediately instead. With CLI apt-get version, it's possible to get it waiting externally (by taking the lock manually, and then make apt-get not try to lock it again). Unfortunately the same cannot be done for the API version, because there is no way (I can find) to disable locking in the apt.Cache.update() function. Workaround for missing feature https://bugs.debian.org/1069167
apt-get uses fcntl F_SETLK for locking, not flock(). Update the function
accordingly.
Fixes: 8fa2929 "vmupdate: wait for other apt-get to complete"