Fix stackoverflow issue with dividing localoperator #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
Gertian
reviewed
Sep 10, 2024
| @@ -66,17 +66,8 @@ end | |||
| Base.:*(a::LocalOperator, b::Number) = rmul!(deepcopy(a), b) | |||
| Base.:*(a::Number, b::LocalOperator) = lmul!(a, deepcopy(b)) | |||
|
|
|||
| function LinearAlgebra.rdiv!(a::LocalOperator, b::Number) | |||
There was a problem hiding this comment.
@lkdvos , could you explain why this would give a stack overflow ?
There was a problem hiding this comment.
The previous definition was a / b = deepcopy(a) / b, and because the deepcopy does not change the type that just recurses infinitely. It should have been rdiv!(deepcopy(a), b), but it seems like either rdiv or ldiv was not defined for tensor maps, (and braiding tensors), so I just simplified the entire thing a bit.
There was a problem hiding this comment.
Oh I see, that's funny !
Thanks for taking the time to explain :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.