Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for binary STLs with 'solid' header and fix STLDocument #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MHebes
Copy link

@MHebes MHebes commented Jan 2, 2025

Fixes #26

@JoshMcCullough ping

Copy link
Member

@JoshMcCullough JoshMcCullough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. Couple tweaks...

src/STLDocument.cs Outdated Show resolved Hide resolved
src/STLDocument.cs Show resolved Hide resolved
@MHebes
Copy link
Author

MHebes commented Jan 2, 2025

@JoshMcCullough Responding to all your comments at once: It appears that const in C# is only allowed for numbers, Boolean values, strings, or a null reference and is not equivalent to the const keyword in e.g. JavaScript.

It is my understanding that const in C# means "has static storage and can be initialized at compile time" rather than "cannot be changed post initialization". The latter refers to readonly, which is only applicable to class members and not local variables.

@MHebes
Copy link
Author

MHebes commented Jan 2, 2025

Happy to adjust whitespace or formatting as you wish, though. I had a lot of trouble getting the pre-push git hook working on windows + git bash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Binary STLs with "solid" prefix better.
2 participants