-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor schema generation #701
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 85.38% 84.91% -0.48%
==========================================
Files 89 91 +2
Lines 7563 7682 +119
==========================================
+ Hits 6458 6523 +65
- Misses 1105 1159 +54
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
In the next PR I/John intend to tackle the error messages. Currently we do a basic validation (on structure only, not based on what API accepts) and code generation in the same sweep but the next implementation will split the errors into a separate scan while keeping the code written here as just the emission of the task IR. |
Code Gen for various parts of the schema create a
Results
object that stores the main results for the codegen.These objects have some internal API's that make it useful for composing results objects together, namely
slice
andappend
as these are the two things that need to be done when composing the pwl and pwc sequences together during code generation.