-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Python ABI3 wheels instead of a wheel per Python version #1064
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d22296f
Start compiling code with ABI
IvanIsCoding 43908ab
Copy code from Qiskit
IvanIsCoding 593c522
Remove duplicates
IvanIsCoding 5da92e4
Trigger action on fork report
IvanIsCoding 519a6b1
Test action
IvanIsCoding 94fc744
Merge remote-tracking branch 'upstream/main' into stable-abi-work
IvanIsCoding 32e6886
Skip musl in ppc64
IvanIsCoding 46daedf
Merge remote-tracking branch 'upstream/main' into stable-abi-work
IvanIsCoding 2a26db6
Restore abi-py38
IvanIsCoding 27df55e
Version bumps
IvanIsCoding c5046af
Take into account Mac OS ARM changes
IvanIsCoding 11049ac
Testing build process
IvanIsCoding fb69db8
Re-triggering workflow
IvanIsCoding fdf058f
Try again
IvanIsCoding dfd99de
Fix upload v4 use
IvanIsCoding bbb9a62
Fix all upload uses
IvanIsCoding 6b9191f
Repair wheels for macos and windows as well
IvanIsCoding 13c28d9
Use fixed version of abi3audit
IvanIsCoding 4b49f6a
Use cibuildwheel 2.17.0
IvanIsCoding fbad224
Handle delocate not being installed
IvanIsCoding 95a50e2
Handle pipx in macOS arm
IvanIsCoding c9ed25d
Update wheels.yml
IvanIsCoding 808b4f4
Test download-artifact v4
IvanIsCoding 039ceef
Add release notes
IvanIsCoding 4de6364
Merge branch 'main' into stable-abi-work
IvanIsCoding bdbe0b4
Merge branch 'main' into stable-abi-work
IvanIsCoding 227d429
Merge branch 'main' into stable-abi-work
IvanIsCoding 684d705
Merge branch 'main' into stable-abi-work
IvanIsCoding f86f698
Merge remote-tracking branch 'upstream/main' into stable-abi-work
IvanIsCoding f01a7e2
Merge branch 'main' into stable-abi-work
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
features: | ||
- | | ||
rustworkx wheels are now built against Python's stable | ||
Application Binary Interface (ABI). For rustworkx users, this means | ||
that wheels distributed by us via PyPI will continue to work with | ||
newer versions of Python without having to recompile the code. | ||
This change will also simplify the release process for the developers | ||
and reduce the storage size required to mirror rustworkx wheels. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's good to bump this to 3.10 since 3.8 goes eol in october (which is a good reminder for us to start emitting a deprecation warning on 3.8 in 0.15.0). But I'm wondering if there was something that required us to move to 3.10 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning was that macOS Arm only runs 3.10+ and I wanted to make it consistent