Skip to content

Commit

Permalink
simde: arm: drop build of cadd and cmla operations files
Browse files Browse the repository at this point in the history
Compilation of Source/WTF/wtf/simde/arm/neon.h failed when using
ARM GCC 11. This header is generated from simd-everywhere,
simd-everywhere encountering the same issue when building
following files:
- simde/arm/neon/cadd_rot270.h
- simde/arm/neon/cadd_rot90.h
- simde/arm/neon/cmla_lane.h
- simde/arm/neon/cmla_rot180_lane.h
- simde/arm/neon/cmla_rot270_lane.h
- simde/arm/neon/cmla_rot90_lane.h

WebKit does not call any functions from those files,
so they are excluded from the build as a workaround.

Refer to issue [1] for more details.

Link: [1]: simd-everywhere/simde#1211

Signed-off-by: LI Qingwu <[email protected]>
  • Loading branch information
Qingwu-Li committed Sep 12, 2024
1 parent bdba4ed commit c7c62f8
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Source/WTF/wtf/simde/arm/neon.h
Original file line number Diff line number Diff line change
Expand Up @@ -44210,6 +44210,8 @@ HEDLEY_DIAGNOSTIC_PUSH
SIMDE_DISABLE_UNWANTED_DIAGNOSTICS
SIMDE_BEGIN_DECLS_

#if SIMDE_ARM_NEON_CMLA_LANE_H_ORIGINAL

SIMDE_FUNCTION_ATTRIBUTES
simde_float16x4_t simde_vcmla_lane_f16(simde_float16x4_t r, simde_float16x4_t a, simde_float16x4_t b, const int lane)
SIMDE_REQUIRE_CONSTANT_RANGE(lane, 0, 1)
Expand Down Expand Up @@ -44459,6 +44461,9 @@ simde_float32x4_t simde_vcmlaq_laneq_f32(simde_float32x4_t r, simde_float32x4_t
#endif
return simde_float32x4_from_private(r_);
}

#endif /* (SIMDE_ARM_NEON_CMLA_LANE_H_ORIGINAL) */

#if defined(SIMDE_ARM_NEON_A32V8_ENABLE_NATIVE_ALIASES)
#undef vcmlaq_laneq_f32
#define vcmlaq_laneq_f32(r, a, b, lane) simde_vcmlaq_laneq_f32(r, a, b, lane)
Expand Down
9 changes: 9 additions & 0 deletions Source/WTF/wtf/simde/simde.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@
#endif
#endif

#if defined(__GNUC__) && (__GNUC__ == 11)
#define SIMDE_ARM_NEON_CADD_ROT270_H
#define SIMDE_ARM_NEON_CADD_ROT90_H
#define SIMDE_ARM_NEON_CMLA_LANE_H_ORIGINAL 0
#define SIMDE_ARM_NEON_CMLA_ROT180_LANE_H
#define SIMDE_ARM_NEON_CMLA_ROT270_LANE_H
#define SIMDE_ARM_NEON_CMLA_ROT90_LANE_H
#endif

IGNORE_WARNINGS_BEGIN("constant-conversion")
#include <wtf/simde/arm/neon.h>
#include <wtf/simde/arm/sve.h>
Expand Down

0 comments on commit c7c62f8

Please sign in to comment.