Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules/lib): deprecate qbx.playAudio #655

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Jan 9, 2025

Description

Marks qbx.playAudio as deprecated since we now utilize mana_audio. Closes #492 upon merging.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mana_audio doesn't return the soundId so not sure it's exactly a 1:1 replacement

@mafewtm
Copy link
Member Author

mafewtm commented Jan 9, 2025

mana_audio doesn't return the soundId so not sure it's exactly a 1:1 replacement

It's not meant to be a one of one replacement. The issue was brought up about it being unnecessary, pointless, not networked, and now that we have our own sound resource that relatively the same thing, but better, I decided to toss a PR in for deprecation. If we wanna keep it then that's fine. I just figured we wanna steer people to use mana_audio instead

Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can always improve mana_audio to handle more than just sound clips if we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SUGGESTION] Sound Broadcast
2 participants