-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project metadata #17
Conversation
Point people to GitHub, not Launchpad. All that's left on Launchpad are a bunch of stale bugs. Update the author field to reflect the large number of contributors. Remove the maintainer field because a bug in something (setuptools?) overwrites the author field with the maintainer field when the package gets uploaded to PyPI.
Can the GitHub issues page be enabled in this repository? |
@bitglue, ping? |
Sorry, forgot about this thread. I did get access to Launchpad and did some grooming on the backlog there, but there's more to be done for sure. Would you like to help? If so, I can probably delegate the necessary privileges on GitHub and Launchpad to you. |
@bitglue I'm happy to help as well. |
@myint @sigmavirus24 I've invited both of you to the Pyflakes organization on Github. It looks like we need some adjustment to the Launchpad permissions to allow you to do everything in the bug tracker, so I've reached out to @florentx for that, since he's the administrator there. |
Sounds good. Thanks |
@bitglue do we want to migrate the issues from LaunchPad to here? I can write a script to do so. (I've done the opposite direction already in a separate script.) |
It couldn't hurt. Besides the bug tracker, I don't think Launchpad is doing anything useful. If we migrate that, then we only need to maintain one thing. |
There seems to be an existing Launchpad-to-GitHub issue converter: There is a recent pull request in that repository, which makes me think that the above still works with Launchpad. |
It's been over a year, but I finally tried exporting the issues from Launchpad using https://gist.github.com/myint/df7b7f6a537a19b5a813a6d8b3cec52c If someone enables the issues, I can use the same Here is a test import I did using a temporary repository: |
Note that Launchpad lists 53 open issues, but 2 of them actually have fixes committed. They were just left open. So it is correct for my test repository to have only 51 issues. |
I've marked those two as 'Fix released' |
The importer does add back ticks around |
One thing I probably want to avoid is using my own account to do the importing. Its fine for the temporary repository since I plan to delete it. But for the real permanent thing, I don't want to clutter up my personal "issues" page. Pylint used a "bot" account when they imported their issues from BitBucket. I think it would make sense for me to do the same. |
I did the issue migration there, let me know if I can help somehow. Using a bot account (with an alternative mail - if you have a gmail address, you should be able to use |
@The-Compiler Thanks! I'll let you know if I run into something. |
@bitglue Could you enable "issues" in this repository? Thanks. |
@myint if you contact GitHub (and are really nice), they may help you do a "true" import, with correct usernames. We did this for sympy/sympy from Google Code a while back (see, e.g., sympy/sympy#6000). |
@asmeurer Cool! Hopefully they have support for Launchpad. |
We had to provide the data to them in their own format. This is the script we used (I believe one of the branches on that repo). |
I'm guessing that would be the https://github.com/skirpichev/google-code-issues-migrator/blob/my2/exportissues.py It looks like that eventually got merged into a newer fork (abusalimov/google-code-issues-migrator#1): https://github.com/abusalimov/google-code-issues-migrator/blob/master/exportissues.py The script outputs JSON files. Though, I didn't find any comments explicitly saying this was a format GitHub would accept. |
I just asked GitHub and got an immediate response from Shawna. They have an API for importing issues now. I think the https://gist.github.com/jonmagic/5282384165e0f86ef105 It preserves the issue and comment dates. And it doesn't trigger notifications, so I won't have to worry about spamming watchers even if I add @ mentions. I'll probably try this out in a test repository in a week or so. |
Very nice. Good to know. |
Okay, here is an updated test using the GitHub import API: https://github.com/pyflakes-bot/pyflakes-test-with-at/issues The issues and comments now have their original timestamps. They are owned by the new |
Here is a version with all the closed issues also included. They contain their proper timestamps for when they were closed. https://github.com/pyflakes-bot/pyflakes-test-with-closed/issues |
The user importing the issues needs admin permissions: https://gist.github.com/jonmagic/5282384165e0f86ef105#general-notes I tested this out in the |
@myint if you're ready to do this, I can manage the permissions wrangling etc. |
Great! I'm free right now. |
Sorry @myint, I wasn't paying attention to this issue or my email. Let's schedule a time to do it? Perhaps it'd be easier to just email me with your availability so we don't spam folks here. We can report back with the final date/time |
https://github.com/PyCQA/pyflakes/issues As @jayvdb mentioned, since the Launchpad issues do not use Markdown, there are some formatting issues in the conversion like |
Point people to GitHub, not Launchpad. All that's left on Launchpad are
a bunch of stale bugs.
Update the author field to reflect the large number of contributors.
Remove the maintainer field because a bug in something (setuptools?)
overwrites the author field with the maintainer field when the package
gets uploaded to PyPI.